Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.It would be really beneficial to have some documentation about best practices of starting to use this module.
After having spent some time with it this morning, I really am not sure I'm seeing the benefits I was expecting.
Mostly, I think it's because I don't know where I should look and how it should be working.
The README.txt is good, but there should be a handbook.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | advagg-2189523-8-update-readme.patch | 22.24 KB | mikeytown2 |
| #6 | README-2189523-6.patch | 3.88 KB | mgifford |
| #5 | advagg-2189523-5-update-readme.patch | 7.82 KB | mikeytown2 |
| #4 | README-2189523-4.patch | 3.51 KB | mgifford |
Comments
Comment #1
mikeytown2 CreditAttribution: mikeytown2 commentedA goal of mine is to create a short video explaining what every setting does... Not sure if I will ever get the time to do that though. Most of what is written below can be found in the readme or on the project page. Let me know what questions you have so I can answer them; for example - on this admin page what does this setting do?
The core AdvAgg module only does a couple of things and mainly allows for the sub-modules to work with minimal code needed. Things the core module does:
- Cache the rendered css/js html so pages get generated faster (aggressive cache).
- Generate aggregates in the background so pages get generated faster (if httprl is enabled).
- Combine CSS better than core does by putting media groups together.
- Prevent more than 4095 CSS selectors from being used in a CSS file (prevent IE bug from causing bad things).
- Fix improperly added types (file to external, external to file; only if it was set incorrectly).
Sub modules then take advantage of the AdvAgg hooks to provide additional things.
- CSS/JS minification.
- Bundling to set a target number of files to download on each request (1 css & 1 js is usually not optimal).
- CSS/JS cdn support so jquery and friends can be downloaded from the google cdn.
- CSS/JS validation to make sure your source files for the aggregates are good.
- AdvAgg mod to do some unique things that should speed up the front end and allow for better grouping of CSS & JS.
Comment #2
mgiffordVideos take a bunch of time. I think it's better to focus first on:
Let me see if I can get started on some of 1 & 3. If you want me to proceed with #2 I can start something.
Comment #3
mgiffordNote that https://drupal.org/node/326504 probably needs to be updated to include Advanced CSS/JS Aggregation links as well.
Comment #4
mgiffordThis is just a start, but I wanted to get your feedback on the changes.
I need to improve the formatting.
Comment #5
mikeytown2 CreditAttribution: mikeytown2 commentedReviewing this patch made me create #2202645: Merge Development & Disabled Cache Settings
This patch has been committed. Keep giving me feedback/patches in small portions as that makes it easier to review. Leaving this issue open :)
Side note is I'm trying to follow markdown inside the readme; I put it through a markdown parser every now and then to make sure things look good.
Comment #6
mgiffordThanks @mikeytown2 - glad to be able to help.
In the README.txt there is a menu for "Operations" but not "Perform An Operation". I suspect that the UI for /admin/config/development/performance/advagg/operations should be just "Operations"
Configurations are expected on a module as most have a config page. However, what is an Operations page? What do you mean by Operations? It probably should have an explanation about how these items are grouped.
It should be done at the top of the page as well as in the README file.
The language & case of a button should be consistent with the text describing it. Changed "Delete Unused Aggregates from Database" by capitalizing & removing "the". I don't care if the "the" is there, but I do care that it's consistent.
What are the 3 sections of the Operations page about? Why are they grouped this way? The README.txt should have similar spacing. Not sure how you want to do that.
I've read through all of the documentation on this page and I still don't know when I'd click on those buttons. They all look like things that should happen automatically. There must be a garbage collection feature for this module that generally handles this, right?
I think it might be useful to let folks know that the Information & Operations pages probably aren't needed for most users (unless they are).
Comment #7
mgiffordComment #8
mikeytown2 CreditAttribution: mikeytown2 commentedThanks again :)
This patch has been committed.
Edit: This as well http://drupalcode.org/project/advagg.git/commit/0191a536bd639ef53ec6748c...
Comment #9
mgiffordGlad to help..
Comment #10
mikeytown2 CreditAttribution: mikeytown2 commentedHave anything else? It really helps when I have someone else tell me what is confusing :)
If not go ahead and change this issue to fixed.
Comment #11
mgiffordI should get through the sub-modules before closing it.
So I'm right then about my assumptions with the Operations & Information pages? Really it's there for debugging, developing or when you just need to say WTF?
Most users shouldn't need to worry about those two pages I assume.
Comment #12
mikeytown2 CreditAttribution: mikeytown2 commentedThat is correct.
Comment #13
mikeytown2 CreditAttribution: mikeytown2 commentedI'm going to work on the admin side of the advagg mod module. It could use some cleanup.
#2207075: Clean up advagg_mod admin page
Comment #14
mikeytown2 CreditAttribution: mikeytown2 commentedAnything else to add? I'll be trying to get a new version out sometime next week and I would like to have any additional contributions from you included :)
Comment #15
mgiffordI think I'm going to have to wait a bit before contributing more.. Got a few other fires on the burner I need to take care of first.
Comment #16
mikeytown2 CreditAttribution: mikeytown2 commentedMarking this as postponed until I get more feedback :)
Comment #17
mgiffordMakes sense.
Comment #18
mikeytown2 CreditAttribution: mikeytown2 commentedMore things to add to the Readme
http://drupal.stackexchange.com/questions/107311/eliminate-render-blocki...
Also got me thinking that I should have an experimental JS setting for adding async to all script tags.
Comment #19
mikeytown2 CreditAttribution: mikeytown2 commentedCreated #2256551: Explain in the readme.txt how to get the highest pagespeed score & #2256549: Add experimental JS setting for adding async to all script tags
Waiting for more input :)
Comment #20
mikeytown2 CreditAttribution: mikeytown2 commentedMarking this issue as fixed.