[D7] Plume menu

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

You should update your issue with all of the information from the application checklist to make it easier for people to review your project.

Description:

1. A detailed description of what your project does, including how it is different from other, similar projects, if applicable.
2. For themes it's helpful to include a screenshot.
3. A link to your project page.
4. A direct link to your git repository (git clone ...).
5. A list of links to reviews of other project applications that you did.

Automated Review
You have a lot of errors in this project. See http://pareview.sh/pareview/httpgitdrupalorgsandboxflow19902189389git for details.
Please fix and then change status to needs review.

Manual Review
plume_menu.js
Your js doesn't follow the drupal standard. You should rewrite it to be:

(function ($) {
  Drupal.behaviors.plumeMenu = {
    attach: function () {
      if ($("#menu-type-2 li a").hasClass("active") == true) {

        $('#menu-type-2 a.active').closest("ul").addClass("open");
        $('#menu-type-2 a.active').children("ul").addClass("open");

        $("#menu-type-2").accordion({
          container:false,
          initShow: "ul.open", 
          iconTrigger: true
        });
      }
      else {
        $("#menu-type-2").accordion({
          container:false,
          initShow: "#current", 
          iconTrigger: true
        });
      }
    }
  }
})(jQuery);

plume_menu.info
Remove these lines, drupal adds them automatically:

version = "7.x-1.0"
core = "7.x"
project = "Plume menu"
datestamp = "1294378870"

plume_menu.module
A lot of the functions in this module don't follow the naming convention. Your functions that start with an '_' must also use the module name, so they should renamed to '_plume_menu_get_menu_type_1' etc.

Your variables in variable_set and variable_get don't follow naming conventions. They should start with your module name.

You have if statements missing brackets.

Also, comments like "Implements _get_menu_type_1()." Aren't valid comments, those are only for Drupal hooks. You should provide a short, one-line description of what your functions do if they are custom functions and not Drupal hooks.

And lastly, it seems like there is a much easier way to do what you're trying to accomplish. Check out the theme function.
For example, your _display_menu() function might be better accomplished with theme('menu_tree', $variables) and theme('menu_link', $variables);

Edit: added manual review
Edit2: Fixed code block

You don't have a review bonus on this so it's definitely going to take a lot longer to get approved than if you did have one. Check out the review bonus program here: https://drupal.org/node/1975228

Or you can just wait at the bottom of the queue :).

Hi Flow1990,

You still have loads of errors on your pareview report. Will be worth getting those fixed before someone comes along to do a proper review...

As I know, it's a bad practice to store contrib plugin in module directory, please use libraries api.
And additionally:
please use attach: function (context) { instead attach: function () {
and use it here if ($("#menu-type-2 li a").hasClass("active") == true) { as if ($("#menu-type-2 li a", context).hasClass("active") == true) {
And I think you don't need to check == true in condition statement.
Helpful docs:

• Managing JavaScript in Drupal 7
• The Drupal JavaScript API

Not sure if it already does, but it would be cool if this somehow integrated with https://drupal.org/project/menu_block.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.