Currently when the module is uninstalled it deletes all records from the {variable} that start with either "panelizer_defaults_" or "panelizer_node:". This isn't particularly good, it should properly identify the list of variables that could be present and properly run variable_del() on them.

CommentFileSizeAuthor
#5 panelizer-n2190839-5.patch1.61 KBdamienmckenna
#3 panelizer-n2190839-3.patch1.62 KBdamienmckenna
#1 hook_uninstall_should-2190839-1.patch663 bytesannya

Comments

annya’s picture

annya commented
Status: Active » Needs review
StatusFileSize
new hook_uninstall_should-2190839-1.patch663 bytes

I think we can't get all variables, because they depends on panelizer plugins. We can't get panelizer plugins on the stage of panelizer's uninstall, because module has been already disabled. So we have to do direct queries. Please see patch, that delete all variables of panelizer.

jeffdiecks queued 1: hook_uninstall_should-2190839-1.patch for re-testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new panelizer-n2190839-3.patch1.62 KB

Updated to delete all variables based on the installed entities.

Status: Needs review » Needs work

The last submitted patch, 3: panelizer-n2190839-3.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new panelizer-n2190839-5.patch1.61 KB

Doh.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue tags: +SprintWeekend2015

  • DamienMcKenna committed 818ae52 on 7.x-3.x 
    Issue #2190839 by DamienMcKenna, annya: Improved panelizer_uninstall()...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.