[D7] Entityform to node

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxCadila2191015git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

There are coder issues as follows. Please fix them and update the code.

FILE: /var/www/drupal-7-pareview/pareview_temp/entityform_to_node.module
--------------------------------------------------------------------------------
FOUND 29 ERROR(S) AND 4 WARNING(S) AFFECTING 20 LINE(S)
--------------------------------------------------------------------------------
4 | ERROR | The third line in the file doc comment must contain a
| | description and must not be indented
7 | WARNING | Line exceeds 80 characters; contains 102 characters
8 | ERROR | There must be an empty line before the parameter block
8 | ERROR | Missing parameter type at position 1
8 | ERROR | Missing comment for param "$ef" at position 1
9 | ERROR | Missing parameter type at position 2
9 | ERROR | Missing comment for param "$node_type" at position 2
10 | ERROR | Last parameter comment requires a blank newline after it
11 | ERROR | Parameter comment indentation must be 2 additional spaces at
| | position 3
13 | WARNING | Line exceeds 80 characters; contains 85 characters
14 | WARNING | Line exceeds 80 characters; contains 105 characters
17 | ERROR | Return comment indentation must be 2 additional spaces
23 | ERROR | No space before comment text; expected "// 'create_node_type'
| | => TRUE," but found "//'create_node_type' => TRUE,"
26 | ERROR | No space before comment text; expected "// Merge options" but
| | found "//Merge options"
26 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
29 | ERROR | No space before comment text; expected "// Options' shortcuts"
| | but found "//Options' shortcuts"
29 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
36 | ERROR | Concat operator must be surrounded by spaces
55 | ERROR | No space before comment text; expected "// If node has been
| | passed as parameter we won't create new node" but found "//If
| | node has been passed as parameter we won't create new node"
55 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
77 | ERROR | No space before comment text; expected "// If we need to
| | create the field in case if it doesn't exist" but found "//If
| | we need to create the field in case if it doesn't exist"
78 | WARNING | Line exceeds 80 characters; contains 108 characters
78 | ERROR | No space before comment text; expected "// Set it to null just
| | to be sure that we don't have an old value from previous
| | cycle" but found "//Set it to null just to be sure that we
| | don't have an old value from previous cycle"
78 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
78 | ERROR | Comments may not appear after statements.
87 | ERROR | No space before comment text; expected "// And finally if
| | field's instance exists and we have filled property" but found
| | "//And finally if field's instance exists and we have filled
| | property"
87 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
89 | ERROR | No space before comment text; expected "// we copy it" but
| | found "//we copy it"
89 | ERROR | Inline comments must start with a capital letter
89 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
94 | ERROR | No space before comment text; expected "// And save node
| | immediately if needed" but found "//And save node immediately
| | if needed"
94 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
100 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

FILE: /var/www/drupal-7-pareview/pareview_temp/entityform_to_node.rules.inc
--------------------------------------------------------------------------------
FOUND 3 ERROR(S) AND 1 WARNING(S) AFFECTING 3 LINE(S)
--------------------------------------------------------------------------------
2 | ERROR | You must use "/**" style comments for a file comment
7 | WARNING | Format should be "* Implements hook_foo().", "* Implements
| | hook_foo_BAR_ID_bar() for xyz_bar().", or "* Implements
| | hook_foo_BAR_ID_bar() for xyz_bar.tpl.php.".
7 | ERROR | Function comment short description must end with a full stop
90 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

FILE: ...upal-7-pareview/pareview_temp/include/EntityFormToNodeRulesUIConfig.inc
--------------------------------------------------------------------------------
FOUND 11 ERROR(S) AFFECTING 8 LINE(S)
--------------------------------------------------------------------------------
4 | ERROR | The third line in the file doc comment must contain a
| | description and must not be indented
12 | ERROR | No space before comment text; expected "// Will gather errors"
| | but found "//Will gather errors"
12 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
12 | ERROR | Comments may not appear after statements.
15 | ERROR | Concat operator must be surrounded by spaces
15 | ERROR | Concat operator must be surrounded by spaces
89 | ERROR | Missing function doc comment
93 | ERROR | Missing function doc comment
94 | ERROR | No space before comment text; expected "// @todo: Implement this
| | in right way" but found "//@todo: Implement this in right way"
101 | ERROR | Missing function doc comment
103 | ERROR | Files must end in a single new line character

//And save node immediately if needed
if ($save_node) {
entity_save('node', $node);
}
return $node;

In above piece of code can we add proper error/exception handling? What if it fails to create $node object? we should check valid object and if it fails just return false or something.

PAreview still finds a couple minor coding style issues: http://pareview.sh/pareview/httpgitdrupalorgsandboxcadila2191015git

Running this locally for trying out the functionality worked great.

Looks good and works here.

Non-blocking issues:
After reading the project page, I'm not sure what this module does. Can you provide an example of when someone would want to use it? What problem is the module solving? Does this module depend on https://www.drupal.org/project/entityform?

Checked for security, duplication, licensing, use of Drupal API, and individual account, no problems found.

Thanks for your contribution, Cadila!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.