file_unmanaged_copy() calls file_prepare_directory() with the wrong parameters [#2191631]

Problem/Motivation

file_unmanaged_copy() calls file_prepare_directory() without the correct options and therefore directories are not created.

Proposed resolution

Call file_prepare_directory() with the FILE_CREATE_DIRECTORY option.

API changes

n/a

File	Size	Author
filedir_FAIL.patch	1.02 KB	benjy

filedir_PASS.patch	2.01 KB	benjy

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

8 February 2014 at 10:14

Status:

Needs review

» Needs work

The last submitted patch, filedir_FAIL.patch, failed testing.

Comment #2

benjy CreditAttribution: benjy commented 8 February 2014 at 11:01

Status:

Needs work

» Needs review

Back to NR

Comment #3

moshe weitzman CreditAttribution: moshe weitzman commented 8 February 2014 at 12:40

Status:

Needs review

» Reviewed & tested by the community

Thx for the new test.

Comment #4

alexpott

he/they

English

🇪🇺🌍

CreditAttribution: alexpott commented 8 February 2014 at 13:10

Category:	Bug report	» Task
Status:	Reviewed & tested by the community	» Needs work

So I'm not sure if this is actually a bug. If I copy a file on the command line to a non existent directory I get an error message. At the very least we should replicate the bit mask on file_prepare_directory to file_unmanaged_copy. That way the caller could decide whether or not they consider the fact that the destination needs to be created as a bug or not.