The module depends onApache SOLR. It overrides some Apache SOLR configuration variables, calculating the number of results and the age of the content found.

This module provides css and overrides both search templates search-result.tpl.php and search-results.tpl.php. Users can override these templates and the css in their theme.

You can find the sandbox page of the module here

Git URL:- git clone --branch 7.x-1.x http://git.drupal.org/sandbox/probesys/2184225.git solr_google_like

Thanks for reviewing.

CommentFileSizeAuthor
solr_google_like.png73.37 KBprobesys
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

PA robot’s picture

PA robot CreditAttribution: PA robot commented
Issue summary: View changes

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

gobinathm’s picture

gobinathm
he/him
Primary language English
Location Milton, Ontario
CreditAttribution: gobinathm commented
Issue summary: View changes
Status: Needs review » Needs work

Coding / Formatting Standards
The code is clean and I could see no issues in it.
Pareview.sh review seems to be clean : http://pareview.sh/pareview/httpgitdrupalorgsandboxjacobsanford2150745git

Concern :
hook_init() has been used in an incorrect way. as per the present code, this will get executed on any page generation which is unnecessary. You can probally restrict this to search page alone.

HELP Text.
Your project page is not very detailed, please have a look at the tips for a great project page, you may also use HTML-tags for better structure. Language in the text might need to be updated

Note: project with review bonus always get priority.

probesys’s picture

probesys CreditAttribution: probesys commented
Status: Needs work » Needs review

We have detailed the project page
We have limited the $conf definition and the adding of css in the hook_init at the search page as recommended :

function solr_google_like_init() {
  // Setting some variables and css for the search page.
  if (arg(0) == 'search') {
    global $conf;

    // Setting default for highlighted.
    $conf += array(
      'apachesolr_hl_active' => 'true',
      'apachesolr_hl_textsnippetlength' => 200,
      'apachesolr_hl_pretag' => '<em><strong>',
      'apachesolr_hl_posttag' => '</strong></em>',
      'apachesolr_hl_numsnippets' => 1,
      'apachesolr_hl_fieldtohighlight' => array('content'),
    );

    // Custom module css.
    $module_path = drupal_get_path('module', 'solr_google_like');
    drupal_add_css($module_path . '/solr_google_like.css');
  }
}

Thanks for reviewing.

inders’s picture

inders CreditAttribution: inders commented
Issue summary: View changes

Added Git URL in project application.

inders’s picture

inders CreditAttribution: inders commented
Status: Needs review » Needs work

You can keep the template file Clean by moving functions to module file:-

<?php print search_help('search#noresults', drupal_help_arg()); ?>

Would prefer not to call functions from tpl file. you can move this to function :- solr_google_like_preprocess_search_results().

probesys’s picture

probesys CreditAttribution: probesys commented
Status: Needs work » Needs review

The search_help function have been moved from the template to the solr_google_like_preprocess_search_results() hook.

Thanks for reviewing.

alinouman’s picture

alinouman CreditAttribution: alinouman commented
Status: Needs review » Needs work

There is a bug in your code on module file at line 164 . you are trying to assign $result string but it wouldn't assign like that
$result . ' ...';
it should be like it
$result .= ' ...';

probesys’s picture

probesys CreditAttribution: probesys commented
Status: Needs work » Needs review

Right...
set $result .= ' ...';

Thanks for reviewing.

basvanderheijden’s picture

basvanderheijden CreditAttribution: basvanderheijden commented

I've looked at your module, and wondered why you decided to override the noresults theme implementation in solr_google_like_theme_registry_alter with theme_solr_google_like_noresults?
This disables functionality of other modules implementing (the default theme implementation of) theme_apachesolr_search_noresults().

subhojit777’s picture

subhojit777
he/him
Primary language Bengali
CreditAttribution: subhojit777 commented

Good module :)

Some suggestions :-
- We can set custom apachesolr pages. You should include them in hook_init().
- The time formatting should have a setting page. Admin should be able to define the time precision for eg: whether they want to show day or not
- For fomatting time better use format_date(), or try to build a wrapper function around format_date()
- It would be better if admin would be able to write custom no-results-message through UI
- It would be great if the link (shown in green) is clickable too (just like google search)
- I would suggest testing this module with custom theme, that is supposed to override search-results and search-result templates. I see that you are altering theme registry in module. In some cases themers would want to make some changes in templates that is not provided by your module.

Good work (y) - but your module is missing admin UI settings.

Also keep css file under css directory. Just for sake of best practices ;)

subhojit777’s picture

subhojit777
he/him
Primary language Bengali
CreditAttribution: subhojit777 commented
Status: Needs review » Needs work

The module defnintely needs admin UI settings

PA robot’s picture

PA robot CreditAttribution: PA robot commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.