Today I noticed an error message in my logfile pointing to Feed Import.
PHP Fatal error: Declaration of FeedImportSQLHashes::__construct() must be compatible with FeedImportHashManager::__construct($entity_name, $group, $feed_machine_name) in [..]/feed_import/feed_import_base/inc/feed_import.inc on line 1547
Changing the constructor declaration seems to get rid of the error.
- public function __construct($entity_name, $feed_machine_name) {
+ public function __construct($entity_name, $group, $feed_machine_name) {
$this->entity = $entity_name;
$this->feedName = $feed_machine_name;
+ $this->group = $group;
}
Am I missing something?
Comments
Comment #1
Sorin Sarca commentedHow did I miss that?
The real change should be done in the abstract class, since the group it's just an option and is not actually required.
Fixed https://drupal.org/commitlog/commit/29616/e82149958bfa4faad2fada2b773c34...
Thanks for the observation!
Comment #2
Sorin Sarca commented