The Result Summary handler does not render any output if the view has no results regardless of "Display even if view has no result" is checked.

In render(), it simply checks for a $total to determine whether to render the output.

CommentFileSizeAuthor
#1 no_output_display_even_if_no_results-2200899-1.patch598 bytesAnonymous (not verified)

Comments

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new no_output_display_even_if_no_results-2200899-1.patch598 bytes

Patch to force rendering if "Display even if view has no result" is checked.

tatarbj’s picture

tatarbj
Primary language Hungarian
Location Brussels
commented
Status: Active » Reviewed & tested by the community

It is working on our sites, thanks rsmylski.

adee147’s picture

adee147 commented

I was about to submit the exact same patch. Its good that I searched for existing issue first :)

spleshka’s picture

spleshka
he/him
Primary language English
Location UAE
commented

Confirm that this patch works as expected.

ali_b’s picture

ali_b commented

working

kopeboy’s picture

kopeboy
Primary language Italian
Location Milan
commented
Priority: Normal » Major

Still not included?!

spleshka’s picture

spleshka
he/him
Primary language English
Location UAE
commented
Priority: Major » Normal

I don't think we can increase the priority just because the patch is not being commited for a long time. Priority of this issue is still normal, but we all want to get it commited :)

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented

We've recently switched our testing from the old qa.drupal.org to DrupalCI. Because of a bug in the new system, #2623840: Views (D7) patches not being tested, older patches must be re-uploaded. On re-uploading the patch, please set the status to "Needs Review" so that the test bot will add it to its queue.

If all tests pass, change the Status back to "Reviewed & tested by the community". We'll most likely commit the patch immediately without having to go through another round of peer review.

We apologize for the trouble, and appreciate your patience.

gerson.analista’s picture

gerson.analista commented

Patch #1 worked in Views 3.14.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Related issues: +#2469781: 'Display even if view has no result' is ignored for "result summary" in Header and Footer

Closed an exact duplicate: #2469781: 'Display even if view has no result' is ignored for "result summary" in Header and Footer

vinmassaro’s picture

vinmassaro commented

Patch in #1 fixes the issue, thanks.

akucherov’s picture

akucherov commented

Patch #1 is still actual for Views 3.20.

tatarbj’s picture

tatarbj
Primary language Hungarian
Location Brussels
commented
Status: Reviewed & tested by the community » Needs review

I beleive we have totally missed the message by @colan, so i'm changing the status to needs review to allow tests to be executed.

tatarbj’s picture

tatarbj
Primary language Hungarian
Location Brussels
commented
Status: Needs review » Reviewed & tested by the community

Re-tests are OK, so i'm moving it back to RTBC in favor of previous comments.

System Lord’s picture

System Lord commented

If it matters, I'm using 7.x-3.22 and applied patch (manually) and it works.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Reviewed & tested by the community » Fixed
Parent issue: » #2960871: Plan for Views 7.x-3.23 release

Committed. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rgnyldz’s picture

rgnyldz commented

I wanted to do the patch manually but as I see in my code the patch is already applied on line 104. Still the header is not shown on my site if I check "Display even if view has no result" Also not in views preview.

rgnyldz’s picture

rgnyldz commented

Ignore #19 I guess it was a cache after I removed the no results content.