[D7] Secure Services

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxamankanoria2201999git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

@amankanoria, Fix issues generated by http://pareview.sh/pareview/httpgitdrupalorgsandboxamankanoria2201999git

Good issue summary help you to get review of your projects from reviewers. Add below mentioned thing in your issue summary.

GIT clone URL : git clone http://git.drupal.org/sandbox/amankanoria/2201999.git
Get verification of your coding standards from http://pareview.sh/pareview/httpgitdrupalorgsandboxamankanoria2201999git and add this line to your issue summary.

At one time request for one version of project only like secure services 7.x and update your issue title with '[D7] Secure Services' Which is very helpful for filtering project application for review. As mentioned by @PA Robot review bonus. option is available there so help us by reviewing other 3 projects and add your comments URL in issue summary.

Add sufficient summary. currently it does not clarify that how your module do different from Drupal http authentication. And if some similar modules is available there, include them as a similar modules in issue summary.

Hope it help

Thanks

Code too short

This project is too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed. However, we can promote this single project manually to a full project for you.

RTBC is the correct status if you found nothing wrong with the project. We use the single project promote tag to indicate that it should be published manually by a git admin.

@Aman, RTBC means "Reviewed and Tested by the Community".

@klausi and @heddn, I am totally agree with you but this module is really useful as for security reason.

Hoping, @Aman and drupal community can add more features related to security on next releases.

In _secure_services_authenticate_call(), can you combine some of the logic? It seems like there's only 2 cases, either the username is present and user/pass match, or not.
Also in that function, @return void|string should be boolean instead of void. PHP returns NULL when you just use a base return statement.

Otherwise looks great. As per #13, promoting this project and not granting git vetted user status. https://www.drupal.org/project/secure_services

Thanks for your contribution, amankanoria!

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.