Updated: Comment 0

Problem/Motivation

#1959574: Remove the deprecated Drupal 7 Ajax API missed the actual removal of the old API due to a merge conflict. It seemed to be that #2187735-3: Add removal information to docblock of all @deprecated functions was going to solve that,
though it also got lost.

Proposed resolution

Remove it now

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#6 ajax_render-2203239-6.patch6.65 KByesct
#1 ajax_render-2203239-1.patch6.61 KBdawehner

Comments

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review
StatusFileSize
new ajax_render-2203239-1.patch6.61 KB

Rerolled the previous removal patches.

Note: This don't need a change notice, as it was already covered in the other issue.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs review » Reviewed & tested by the community

Bug Report + Critical +Quick fix = RTBC.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

ajax_render-2203239-1.patch no longer applies.

error: patch failed: core/includes/ajax.inc:228
error: core/includes/ajax.inc: patch does not apply
catch’s picture

catch
he/him
Primary language English
commented
Category: Bug report » Task
yesct’s picture

yesct commented
Assigned: Unassigned » yesct

I'm going to reroll this now. https://drupal.org/contributor-tasks/reroll

yesct’s picture

yesct commented
Assigned: yesct » Unassigned
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new ajax_render-2203239-6.patch6.65 KB

There was a difference in the hunk in head that the patch was trying to remove. due to #2045927: Replace all drupal_alter() deprecated function calls.

diff head-hunk.txt patch-hunk.txt
24c24
<       \Drupal::moduleHandler()->alter($type, $items[$type]);
---
>       drupal_alter($type, $items[$type]);
74c74
<   \Drupal::moduleHandler()->alter('ajax_render', $commands);
---
>   drupal_alter('ajax_render', $commands);

Just removed the whole hunk from head.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

back to rtbc

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.