Replace #attached library array values with provider-namespaced strings

There are about 70 instances currently.

Much more than 70 instances. That should be all of them. There was a problem in the comment module, not enough nesting. There are a couple of scripts in node module and another that need to be made into a library and function docs needs to be updated.

+++ b/core/includes/common.inc
@@ -2714,15 +2714,16 @@ function drupal_process_states(&$elements) {
+  list($module, $name) = explode('/', $library_name);

@@ -2780,9 +2781,10 @@ function drupal_add_library($module, $name, $every_page = NULL) {
+  list($extension, $name) = explode('/', $name);

Not that 'core/myspecial/snowflakelibrary' is valid, but this should be list($module, $name) = explode('/', $library_name, 2); just to be safe.

($module vs $extension here, plus we actually use $provider everywhere else in core)

I should have said 70 using the grep in the OP.

addressing #5

attached interdiff with #4

Just a reroll, no interdiff.

Patching without pulling first, been a while since I made that mistake :p

Oh yeah but one change I made earlier is in the library_alter hook,

Before

function hook_library_alter(array &$library, $module, $name) {
  if ($module == 'core' && $name == 'jquery.ui.datepicker') {

when I use it and when I see it used, it's always a check on both module and library so I just removed the module part and send the whole dep string:

function hook_library_alter(array &$library, $name) {
  if ($name == 'core/jquery.ui.datepicker') {

All right, should be green.

aww cmon :p

Reroll, caching patch broke it.

I couldn't find anything broken in manual testing. I read the entire patch, and couldn't find any errors. This is pretty much RTBC, besides these nitpicks:

1. +++ b/core/includes/common.inc
   @@ -2677,9 +2677,7 @@ function drupal_process_states(&$elements) {
   + * @param $library_name
     *   The name of the library to add.
   

   Does this still make sense? It's now a module-namespaced library name.

2. +++ b/core/modules/ckeditor/lib/Drupal/ckeditor/Plugin/Editor/CKEditor.php
   @@ -353,16 +353,14 @@ public function getLangcodes() {
   -      $additional_libraries = array_udiff($plugin->getLibraries($editor), $libraries, function($a, $b) {
   -        return $a[0] === $b[0] && $a[1] === $b[1] ? 0 : 1;
   -      });
   +      $additional_libraries = array_diff($plugin->getLibraries($editor), $libraries);
   

   Nice :)

3. +++ b/core/modules/node/lib/Drupal/node/NodeFormController.php
   @@ -114,6 +114,7 @@ public function form(array $form, array &$form_state) {
   +        // @todo make library.
            'js' => array(drupal_get_path('module', 'node') . '/node.js'),
   
   @@ -154,6 +155,7 @@ public function form(array $form, array &$form_state) {
   +          // @todo make library.
              drupal_get_path('module', 'node') . '/node.js',
   
   @@ -196,6 +198,7 @@ public function form(array $form, array &$form_state) {
   +        // @todo make library.
            'js' => array(drupal_get_path('module', 'node') . '/node.js'),
   

   These are all for the same thing. Let's also create an issue for each @todo. Same for the few other analogous @todos you added.

#2205161: Convert node.js into a library [LOL]

:D :D :D

sun++

Rerolled. And removed todos.

reroll…

BTW updated https://drupal.org/node/1764252 to reflect api change.

core-library-shorthand-2203407-26.patch no longer applies.

error: patch failed: core/modules/picture/lib/Drupal/picture/Plugin/Field/FieldFormatter/PictureFormatter.php:172
error: core/modules/picture/lib/Drupal/picture/Plugin/Field/FieldFormatter/PictureFormatter.php: patch does not apply

Reroll, was because of #2203435: Move all external libraries from core modules into core.libraries.yml

core-library-shorthand-2203407-33.patch no longer applies.

error: patch failed: core/modules/user/lib/Drupal/user/RegisterFormController.php:44
error: core/modules/user/lib/Drupal/user/RegisterFormController.php: patch does not apply

Reroll

Committed 01a3e19 and pushed to 8.x. Thanks!

Also edited: https://drupal.org/node/2169605/revisions/view/6873153/7080183