[D7] Proxy Auto

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi andre4s_y,

You might want to separate the admin settings form in a separate file proxy_auto.admin.inc to minimise the .module file.

You can change this (in the module file):

$menus['admin/config/system/proxy_auto'] = array(
    'title' => 'Proxy Auto Settings',
    'description' => 'Configure Proxy Auto Module',
    'page callback' => 'drupal_get_form',
    'page arguments' => array('proxy_auto_settings'),
    'access arguments' => array('administer site configuration'),
  );

To:

$menus['admin/config/system/proxy_auto'] = array(
    'title' => 'Proxy Auto Settings',
    'description' => 'Configure Proxy Auto Module',
    'page callback' => 'drupal_get_form',
    'page arguments' => array('proxy_auto_settings'),
    'access arguments' => array('administer site configuration'),
    'file' => 'proxy_auto.admin.inc',
  );

and move the settings form function to this file.

A few grammatical changes:

• Line 117: Comment lines will not be included in the output.
• Line 119: Must return a value of type String.
• Line 120: Use spaces instead of tabs.
• Line 182: Proxy configuration content must have at least one return value of type String.

Greets.

Dear andre4s_y,
thanks for submitting this new functionality to the Drupal community.

I installed and tested the module as well as reviewing the code.
I think it works as desired, except I would like you to take a look at the following:

1. Fix the grammar of the rules, as stated by lennartvv above, in README.txt

2. Fix the grammar of the rules in the .module file itself (lines 117-120):

3. In the README.txt, Installation, point 3:

You have:
Edit the proxy configuration file under "Administration" -> "Configuration" -> "Proxy Auto Settings"

It should be:
Edit the proxy configuration file under "Administration" -> "Configuration" -> "System" -> "Proxy Auto Settings"

Good luck,

imgio

Hi andre4s_y,

You are not obliged to add a test file. But it's obviously a nice extra.
You can commit and push all your changes to the current 7.x-1.x branch without making patches.

Good luck!

The function short descriptions use an @desc format that is not customary for Drupal. Please see https://drupal.org/coding-standards/docs#drupal

function proxy_auto_settings_validate()
Validate functions typically do not modify input data. This should only happen when retrieving the stored data. This still applies to Drupal7, see https://drupal.org/node/213156.

Instead it should only be doing form_set_error type logic.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Your code fails automated testing:

http://pareview.sh/pareview/httpgitdrupalorgsandboxandre4sy2202733git

in proxy_auto_settings, you are using html in t() which should be avoided.

You should implement hook_uninstall to remove variables you have created.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.