Don't know why :/

CommentFileSizeAuthor
#7 Screen Shot 2014-03-24 at 8.32.54 am.png776.38 KBPI_Ron
#7 Screen Shot 2014-03-24 at 8.16.05 am.png577.67 KBPI_Ron
#6 radix-radix_layouts_css-2206167-6.patch1.36 KBbarraponto
#3 radix-radix_layouts_css-2206167-3.patch153.65 KBbarraponto

Comments

barraponto’s picture

barraponto
he / him
commented
Title: Homepage responsiveness fails below 780px » Breaks non-layouted pages
Project: radix » Radix Layouts
Version: 7.x-3.x-dev » 7.x-3.0-alpha1

I think Radix Layouts shouldn't add its CSS unless required.

shadcn’s picture

shadcn commented

I was actually working on this bug yesterday. I'll push.

Do you have a screenshot or steps to reproduce?

Thanks

barraponto’s picture

barraponto
he / him
commented
Status: Active » Needs review
StatusFileSize
new radix-radix_layouts_css-2206167-3.patch153.65 KB

I've got better: a patch :D

The issue is that radix_layouts.css applies styles to .container, which is used by Bootstrap (and added in radix's page.tpl.php). My patch avoids adding radix_layouts.css by default, instead declares the CSS to be used in the layout plugin (using hook_ctools_plugin_pre_alter because adding the css key to every single layout plugin would be a pain).

BTW, come back to #panopoly on IRC

shadcn’s picture

shadcn commented
Status: Needs review » Needs work

Thanks for the patch Capi.

The problem with this approach is that if you have custom layouts in your module then this does not get executed.

if ($info['type'] == 'layouts' && $plugin['module'] == 'radix_layouts') {
    //
}
barraponto’s picture

barraponto
he / him
commented

Well, if you have custom layouts in another module, add the CSS from the other module (drupal_get_path will be useful).

barraponto’s picture

barraponto
he / him
commented
Status: Needs work » Needs review
StatusFileSize
new radix-radix_layouts_css-2206167-6.patch1.36 KB

No really, no idea what went into that patch of mine. Here's a sane patch.

PI_Ron’s picture

PI_Ron commented
StatusFileSize
new Screen Shot 2014-03-24 at 8.16.05 am.png577.67 KB
new Screen Shot 2014-03-24 at 8.32.54 am.png776.38 KB

I think an issue I am seeing may be related to this. Please see attached screenshots of site layouts after enabling radix_core & dependencies (with & without radix theme & subtheme enabled).

Disabling radix modules fixes the layout.

barraponto’s picture

barraponto
he / him
commented

I'll really need steps to reproduce this error. And try not to use Radix_Core right now, because I don't think it's up to date.

PI_Ron’s picture

PI_Ron commented

So just download radix_layouts & radix_admin manually?

PI_Ron’s picture

PI_Ron commented

@barraponto please see my comment #15 & #16 in this issue, they have steps I took to produce this error, including using radix_core:

https://drupal.org/comment/8602937#comment-8602937

PI_Ron’s picture

PI_Ron commented

Which version is this patch meant to be applied to?

PI_Ron’s picture

PI_Ron commented

After some testing it appears the layout overlapping issues mentioned in https://drupal.org/comment/8602937#comment-8602937 only appear when using Panopoly 1.2

I've reverted Panopoly to 1.1 and the layouts are working fine.

shadcn’s picture

shadcn commented
Status: Needs review » Fixed

This is now all fixed. See #2334871: Radix Layouts breaks Panopoly for nested panels (e.g. teaser lists).

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.