The Drupal 7 taxonomy migration doesn't take into account the terms possibly having multiple parents.

Patch to follow.

CommentFileSizeAuthor
#4 migrate_d2d-d7-multiple-term-parents-2206729-4.patch1.32 KBmikeryan
#3 migrate_d2d-d7-taxonomy-multiple-parents-2206729-3.patch1019 bytesmsmithcti
#1 migrate_d2d-d7-taxonomy-multiple-parents-2206729-1.patch696 bytesmsmithcti
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

msmithcti’s picture

msmithcti CreditAttribution: msmithcti commented
FileSize
migrate_d2d-d7-taxonomy-multiple-parents-2206729-1.patch696 bytes

This patch copies almost verbatim the approach from the D6 taxonomy migration class. It seems to work well with the current dataset I am working with, however there a few issues with it:

  • I'm not sure ordering the query by the parent ID is a failsafe way of ensuring parents are migrated first. The lowest TID isn't necessarily the parentmost.
  • The UI displays more records than there actually is terms to migrate as there is some duplication in terms returned by the query.
  • An additional query has to be run for each row imported.
msmithcti’s picture

msmithcti CreditAttribution: msmithcti commented
Status: Active » Needs review
msmithcti’s picture

msmithcti CreditAttribution: msmithcti commented
FileSize
migrate_d2d-d7-taxonomy-multiple-parents-2206729-3.patch1019 bytes

The addition of a group by in the query prevents a miscalculation of the number of rows to be imported.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan commented
FileSize
migrate_d2d-d7-multiple-term-parents-2206729-4.patch1.32 KB

How about this, making it more similar to the D6 implementation?

  • mikeryan committed 1e234a6 on 7.x-2.x 
    Issue #2206729 by splatio,mikeryan: Handle multiple term parents from D7
mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan commented

Committed, thanks!

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.