Try and build /forum and /forum/{tid} with views

The attached patch no longer applies, and when manually recreating it, no longer works as advertised. I started working on it, but haven't got far enough to address the functionality that no longer works.

This issue was marked as a beta target for the 8.0.x beta, but is not applicable as an 8.1.x beta target, so untagging.

As a disruptive change, this would need to be targeted for 8.2.x at this point.

Rerolled, omitted this change:

+++ b/core/modules/taxonomy/taxonomy.views.inc
@@ -338,6 +338,7 @@ function taxonomy_views_data() {
+      'id' => 'standard',

This is now already done on Drupal\taxonomy\TermViewsData::getViewsData()

I've been playing around with the patch, the view doesn't even show up. Looks to me like we might be better off with rebuilding the view by hand.

We should probably do that, export it and put it under core/modules/forum/config/optional/views.view.forum_forums.yml

It's works for me!

Thanks @cebasqueira, for those wondering, patch #15 moves the file into the optional folder.

$ diff core/modules/forum/config/optional/views.view.forum_forums.yml core/modules/forum/config/views.view.forum_forums.yml -s
Files core/modules/forum/config/optional/views.view.forum_forums.yml and core/modules/forum/config/views.view.forum_forums.yml are identical

@faline, we still need to get the view re-done & re-exported for this to work, setting this to Needs work.

I tried to reimplement view again for 8.4.x branch.
I have attached implementation for view. I have noticed following things that needs some work on below topics, and need some help in those.

It causes some issues in displaying latest comment date.
View doesn't displays results when we don't have any containers around forum.

@mohit_aghera we need to resolve #2086125: Last read comment field/filter/argument uses still the node.changed instead of node_field_data.changed column for latest comment dates.

Added issue linked in #25 as related

Patch created after test fixed, Please review.

More test fixed, Please review.

More test fixing, Please review.

Try to fix tests, Please review.

Thanks for working on this @vsujeetkumar, I thought I'd give it another push:

+++ b/core/modules/forum/config/optional/views.view.forum_forums.yml
@@ -0,0 +1,801 @@
+uuid: d6783039-0fcb-4a96-99a5-796b62a626df

uuid should be omitted, since this is a default view.

Updating Upgrade7Test and Upgrade6Test view counts since we are adding a new view here.

I also imported, saved and re-exported the view to get the correct configuration which should also get \Drupal\KernelTests\Config\DefaultConfigTest passing.

Let's try that again.

I haven't even applied the patch yet, so these are just general observations.

We need screenshot of how the new view looks, to compare to the non-view situation. Also some form of test coverage would be nice, but not sure how that should look. Should all functional tests pass when switching to the view-version? How do we want to be sure we are not losing any functionality?

Also, I think the scope of the issue is a little too big. 'create /forum and /forum/x' should probably be split up into two issues, or is there a hard reason that these need to be moved over at the same time?

Should we change project from 'Drupal Core' to 'Forum' since Forum has splitted from core?

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Forum is approved for removal. See #1898812: [policy] Deprecate forum module for removal in Drupal 11

This is now Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

It will be moved to the contributed extension once the Drupal 11 branch is open.

And no longer a child of the core issue.

Things to fix (work in progress):

1. The view does not show any results if the forums do not have any containers as parents. The fix: Containers are not required, so the Parent view relationship should not be required.
2. It shows unpublished forums. The fix: Add a filter to only include published terms.
3. Last post date is shown as an integer.
4. Forum description HTML is not rendered if the view is aggregated, which it is. It's displayed as plain text, showing the HTML tags. The fix: Add "format" as an additional "group column" in the field's aggregation settings.

None of the existing patches are against the contrib module.

I added patch #39 to the MR, then made some initial fixes (fixing #1, 2, and 4 in my earlier comment) and re-exported config.

For some reason, "n/a" doesn't get displayed if there is no "most recent post". Not sure why. There must be some limitation on what Twig logic is allowed in views?

The main forum listing is done. If someone else wants to look at it and see if it looks good, this view could replace the current functionality. Then work can be done on the next piece if desired.