[D7] One time login password

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hello,

Thank you for contributing.

It should say: git clone --branch master http://git.drupal.org/sandbox/wbressers/2159381.git one_time_login_password

Otherwise, this module is ok for me.

NerOcrO

Yes, indeed, my bad :)

Fantastic idea! And I see an admin can still use drush uli to log in as another user, so that's good.

I have one question. I didn't look at the code very long. What does

$_SESSION['pass_reset_' . $account->uid]

do? Is it being used in user_profile_form_submit() or user_login_finalize()?

Force Password Change module seems to do most of these, why don't you work with that module maintainer. In-fact there is a feature request submitted on the issue queue to include this functionality.

Looks like this functionality should be incorporated in the existing Force Password Change module. As you are aware our Drupal community strongly believe Collaboration rather than competition. Please work with the existing module maintainer, provide patch for the existing issue. Apart from this you can also get in touch with the maintainer(s) & see how to incorporate this feature in that module.

as a druplar i request you to work & update the existing Force Password Change module and not creating another module for doing the same functionality.

Cool little module that does what it says and nothing more. It adds the password-fields to the page you get linked to when resetting your password and forces you to set a new password.

I just installed it in my own site and it works fine. Code looks good.

Regarding gobinathm's comment; I don't think this module is competition for Force Password Change. It only offers a tiny bit of functionality currently not found there. Sure, this could be incorporated into that module, but then I would probably still keep this little module alive. Why install a big(ger) module when a tiny one does the job you need?

function one_time_login_password_menu_alter(&$items) {
  $items['user/reset/%/%/%']['page arguments'][0] = 'one_time_login_password_user_pass_reset';
  unset($items['user/reset/%/%/%']['file']);
}

This won't play nicely if someone already has an alter on the menu. Perhaps replace with this or something similar.
$items['user/reset/%/%/%']['page arguments'][] = 'one_time_login_password_user_pass_reset';

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

@heddn your solution will not work; the page callback is drupal_get_form which expects argument 0 to be the form name.

Marking this as RBTC so someone can convert this into a module (just like was done with my module: https://www.drupal.org/node/2154791#comment-8681831).

Then use array_unshift. But don't replace the first position on the submit handlers, unless there is good reason.

Where do you see it's replacing submit-handlers ?

The menu_alter is replaceing the first argument that's being sent to drupal_get_form. No way around it. Using array_unshift will mess things up more (the original first argument will be used as $form??)

You've listed Simple Password Reset as a similar module, but it seems to provide exactly the same functionality. Can you explain the difference?

The menu_alter hook looks fine, as SpadXIII points out its modifying the page arguments, not submit handlers.

The code is pretty short, but we no longer require that to pass an application. Additionally the applicant has many larger commits on other projects that show good use of the Drupal API.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.