Trying to combine multiple projects together. Modules that extend EFQ

~/gotta_download_them_all$ grep -l -r -i "extends EntityFieldQuery {" ./
./allmodules/apachesolr_attachments/apachesolr_attachments.module
./allmodules/bean_relevant/plugins/bean/bean_relevant.inc
./allmodules/efq_extra_field/efq_extra_field.module
./allmodules/field_analytics/field_analytics.efq.inc
./allmodules/relation/relation.database.inc
./allmodules/time_entry/time_entry.module
./allmodules/imageinfo_cache/imageinfo_cache.drush.inc
./allmodules/brewery_db/modules/brewery_db_beer/class/brewery_db_beer.entity.inc
./allmodules/themekey/ThemeKeyEntityFieldQuery.php
./allmodules/weight_efq/weight_efq.module

Comments

mikeytown2’s picture

mikeytown2 commented

Created a sandbox for my work

https://drupal.org/sandbox/mikeytown2/2209909

http://drupalcode.org/sandbox/mikeytown2/2209909.git/blob/refs/heads/mas...

mikeytown2’s picture

mikeytown2 commented
Issue summary: View changes
nick_vh’s picture

nick_vh
he/him
Location Ghent
commented

Before you do so, this subject has been quite controversial. Can you please explain in more detail what you are trying to do?

mikeytown2’s picture

mikeytown2 commented

How has EFQ been controversial?

My sandbox was built off of the apache solr code and after using gotta_download_them_all to see what other modules extend EFQ I discovered this project and seems like the code I've been working on would belong in here.

My sandbox
- renames addExtraField to getFieldValue getting rid of alias and add in a join type; default is LEFT.
- getPropertyValue to get propery values
- allows for filtering on roles
- ->propertyCondition('rid', array(4, 6, 12))
- ->propertyCondition('rolename', 'webmaster')
- showQuery will output a ready to drop in phpmyadmin query in ['#query']

Going to work on a fake node/user object loader so the fields that get loaded will be in $node->field[und][0][value] if EFQ is finished by something like executeEntityBuild();

Also have a real loader that will use entity_load to load in the full object. Call it executeEntityLoad();

mikeytown2’s picture

mikeytown2 commented

Work on executeEntityBuild & executeEntityLoad is done. I checked the other modules that extend EFQ and I didn't find much in terms of generic code.

mikeytown2’s picture

mikeytown2 commented

I've improved the output from executeEntityBuild so that roles and data is show correctly.

fabianx’s picture

fabianx commented

Nice work, mikeytown2! As always!

david_garcia’s picture

david_garcia commented

@mikeytown2 This should be turned into it's own module, incredible work.