[D7] Styled Google Map

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxiampuma2208445git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi there,

styled_google_map.info
I can see that the system_stream_wrapper module is a dependency but I can only see two instances where it is being utilised.
Additional modules can add overhead, does system_stream_wrapper provide any gains over drupal_get_path in this scenario? (Could be that it does, just wanted to raise the point).

styled_google_map.module
The PHPDoc comment is missing the @return tag

styled-google-map.js
Comma on last array element needs to be removed. line 10 and line 32
Unnecessary comment on line 13

README.txt
Inconsistency for "Geofield" capitalisation line 4
Spelling error for "desired" line 32

Otherwise it all looks good.
I've installed the module successfully and implemented the display with various configurations that all work as expected.

Edit:
The git command in the original post should be:
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/iampuma/2208445.git styled_google_map

Hi there

I tried your module and it seems very ok. I would modify this only this:

'#options' => array(1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19),

into this:

'#options' => range(1,19),

everywhere you defined this array in your code. But it is only a matter of major code cleanup, the rest seems ok!!

Module looks good. It installed without issues and I was able to add a map to a content page. Paraview reports a few minor errors (http://pareview.sh/pareview/httpgitdrupalorgsandboxiampuma2208445git). But otherwise, the module, from my perspective, follows the checks describe here as well: https://www.drupal.org/node/1587704.

My only suggestion would be to add some additional documentation. For example there is no in-line documentation for the functions:

• styled_google_map_field_formatter_settings_form()
• styled_google_map_field_formatter_settings_summary()
• styled_google_map_field_formatter_view()

Those functions all have some control logic which can help if described a bit. Also, you may want to describe how this module is significantly different from the Google Map Field module. But despite some of these minor issues looks good and works well!

the new functionality works. I'm using it in two projects and haven't had any problems.

Works like a charm, thank you.

Sorry for the delay. Make sure to finish your review bonus next time and this will get processed faster.

Review of the 7.x-1.x branch (commit 3d2c95a):

• DrupalPractice has found some issues with your code, but could be false positives.
  

  FILE: /home/klausi/pareview_temp/styled_google_map.module
  ---------------------------------------------------------------------------
  FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
  ---------------------------------------------------------------------------
   6 | WARNING | @author tags are not usually used in Drupal, because over
     |         | time multiple contributors will touch the code anyway
  ---------------------------------------------------------------------------
  

• No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

1. project page is a bit short. Perhaps you could add more useful information according to https://www.drupal.org/node/997024 ?
2. You have committed styled_google_map.rar to git which is a broken RAR archive of the module and should be removed.
3. styled_google_map_field_formatter_view(): no need to use #markup here, you can directly use your theme function with the #theme key in render arrays, see https://www.drupal.org/node/930760
4. styled_google_map_field_formatter_settings_summary(): The ":" placeholder does not exist for t(). Use "@" or "%" instead, see https://api.drupal.org/api/drupal/includes!bootstrap.inc/function/t/7
5. theme_styled_google_map(): this is vulnerable to XSS exploits. If I enter 5'"><script>alert('width');</script> as width in the formatter settings I will get a nasty javascript popup when the field is displayed. You need to sanitize all user provided text before printing to HTML. Make sure to read https://www.drupal.org/node/28984 again. And please don't remove the security tag, we keep that for statistics and to show examples of security problems.

Fixing tag.

Review of the 7.x-1.x branch (commit 07e66e5):

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
  

  
  FILE: /home/klausi/pareview_temp/styled_google_map.module
  --------------------------------------------------------------------------------
  FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
  --------------------------------------------------------------------------------
   396 | WARNING | Line exceeds 80 characters; contains 88 characters
  --------------------------------------------------------------------------------
  
  Time: 327ms; Memory: 10.5Mb
  

• No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

1. styled_google_map_field_formatter_view(): do not call theme() here, just return the render arrays, Drupal will render them later for you. See https://www.drupal.org/node/930760
2. styled_google_map_field_formatter_settings_summary(): The ":" placeholder does not exist for t(). Use "@" or "%" instead, see https://api.drupal.org/api/drupal/includes!bootstrap.inc/function/t/7

But otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to dman as he might have time to take a final look at this.

Sorry, I got to this first on account of the ticket being so old. Thanks for addressing the duplication issue on the project page. Did not find any security, licensing, Drupal API, or individual account issues.

Thanks for your contribution, iampuma!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.