Been dealing with these issues for a while now. Just upgraded to 7.x-3.9 and am still observing the following issues:

  1. If you are following a node and you add a comment, whether you authored it or not, in both cases you are sent an email notification
  2. If, in your notification settings/followed content list, you have "don't email" checked, you are still email notified. A previous case was closed but the problem seems to still exist. #2001702: Message Subscribe sends emails regardless of flag checkmarks in notification-settings
  3. If you are following a user, and you add a comment to that user's content, you get an email that you just added a comment.
  4. Adding node or comment automatically subscribes you and triggers emails of the sort described above. I think this would be solved if the don't email followed content check box were respected.

Putting this as a major priority.

Comments

mpaler’s picture

mpaler commented
Issue summary: View changes
mpaler’s picture

mpaler commented
Issue summary: View changes
mpaler’s picture

mpaler commented

I should point out these issues center around notifications of a custom content type (forum) added to the commons framework:

function my_module_commons_entity_integration() {
  return array(
    'node' => array(
      'forum' => array(
        'is_group_content' => FALSE,
       // 'exclude_commons_follow' => TRUE,
      ),
    ),
  );
}
japerry’s picture

japerry
Location KOMK
commented
Assigned: Unassigned » japerry
mpaler’s picture

mpaler commented

To do: test this patch.

mpaler’s picture

mpaler commented

From what I can tell, it seems that being email notified when you post a comment or node is by design as D.org does this for issue threads. I'm about to be notified that I just posted this comment. I guess that's an acceptable behavior.

mpaler’s picture

mpaler commented

For #2 above (Email notifications not respecting notification flags), i believe this may be an issue over in the message subscribe module. There's an uncommitted patch over there that fixes the problem for me.

I think if #2 is resolved, it could be enough to close this ticket, though we may still need to test the "Notify author of their own submissions" setting over at admin/config/system/message-subscribe

japerry’s picture

japerry
Location KOMK
commented
Version: 7.x-3.9 » 7.x-3.x-dev
Status: Active » Needs work

After further review of #1828184: Message Subscribe sends emails regardless of context, I think we're getting closer. However, still having issues, specifically around following others causes the person you follow to receive notifications on content that the follower makes.

This makes me think that there is an issue around the flag id, and it needs to be limited to a single flag type (email_node, email_group, etc), we're grabbing all right now. Instead we should find the relevant type from $values['entity_type'] and apply it to the correct email flag.

To verify we're seeing the correct items, I laid out the following scenarios:

If following group…. and email enabled
-- should see new nodes in group
-- should see new comments on nodes in group

If following node… and email enabled
-- should see new comments on node

if following user… and email enabled
-- should see new nodes by user
-- should see new comments by user

I noticed that Devin's tests in message_subscribe are failing, which is probably indicative that these scenarios are not being correctly executed. I ran into a roadblock today trying to figure out if we want to do the email filtering inside message_subscribe_email, or if its something commons specific. It'd be easier to do on the message_subscribe_email side instead of making yet another alter that comes after the email alter.

japerry’s picture

japerry
Location KOMK
commented
Status: Needs work » Needs review

After going through all of the tests and finding out my mistake (a group was selected, which was sending emails correctly), I believe #55 in #1828184: Message Subscribe sends emails regardless of context fixes this issue. Will discuss with team tomorrow and see if we can get it pushed upstream, otherwise we'll add a patch to the make file.

  • Commit 29b3f20 on 7.x-3.x by japerry: 
    Issue #2210829 patch for fixing erroneous notification messages being...
Leeteq’s picture

Leeteq commented
Status: Needs review » Fixed

So this fix made it into 3.13.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.