Subdir aliases prevent non-subdir aliases from working [#2213387]

If you have the subdirectories module enabled, and define a list of aliases for your site:

Site: a.foo.com
Alias: b.foo.com
Alias: c.foo.com
Alias: foo.com/a

Only a.foo.com and foo.com/a will work. If you remove foo.com/a from the list of aliases, then b.foo.com and c.foo.com will work. The reason is that the $PLATFORM/sites/sites.php doesn't include the b.foo.com and c.foo.com aliases when there is a subdirectory alias for the site as well. Something is causing those aliases to not be accounted for when updating sites.php.

I'll look at seeing if I can isolate where this occurs but wanted to get the bug written up.

Comment	File	Size	Author
#3	0001-Fix-alias-handling-when-using-subdirs-support-Drupal.patch	1.45 KB	cmoates

Comments

Comment #1

cmoates commented 7 March 2014 at 23:19

Title:

Subdir aliases prevent non-subdir aliases from workign

» Subdir aliases prevent non-subdir aliases from working

Comment #2

cmoates commented 7 March 2014 at 23:20

The issue is in provision/subdirs/Provision/Config/subdirs_drupal_sites.tpl.php.

There is a logic error in the loop in this template which assumes that all aliases are subdir aliases. It's an easy patch to fix it up, I'll get something whipped up and attached.

Comment #3

cmoates commented 8 March 2014 at 02:36

Status:

Active

» Needs review

Status	File	Size
new	0001-Fix-alias-handling-when-using-subdirs-support-Drupal.patch	1.45 KB

I've attached a patch that fixes the buggy behavior. I simply check each alias to see if it's a subdir alias or not, and if not, simply skip over the fancy schmancy munging and subsequent unset() call that was causing the issue. Tested in my environment to be working as expected.