[D7] TukTuk

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxjkswoods2188627git

I'm a robot and this is an automated message from Project Applications Scraper.

This is a nice clean starting point for theming from, nice work.

I'm still taking a detailed look at things, but here's a few notes:

• Does not include a screenshot image.
• Repeated error message (only visible in admin):
  Notice: Undefined index: class in tuktuk_image() (line 30 of /[site docroot]/sites/all/themes/tuktuk/template.php).
  Line 30 should be the following (class is an array so multiple values can be added to it if needed):
  $attributes['class'][] = 'responsive';
• Images used in content are rescaled (even upscaled) to fit width of content area. This causes some big issues if you try using it with the forum module or sortable tables that use icons for sort order. It might work better to change the styles for img.responsive to eliminate the width property and replace it with max-width:100% instead (so large images in small spaces will be scaled down, but small images in large spaces won't be scaled up).
• JavaScript error in tuktuk.js:
  

  [Error] TypeError: 'undefined' is not an object (evaluating '$.apply')
  dom (tuktuk.js, line 26)
  (anonymous function) (tuktuk.js, line 30)

• Theme tries to add file tuktukoverrides.js that doesn't actually exist in the codebase leading to a JS error:
  [Error] Failed to load resource: the server responded with a status of 404 (Not Found) (tuktukoverrides.js, line 0)
• Since Google Fonts (as included remote through the @import directive mentioned above) is actually licensed under the SIL Open Font License and not the GPL I'm not sure if this causes hiccups with the GPL licensing requirement for code hosted/distributed through drupal.org. References: Wikipedia: Google Fonts, Wikipedia: SIL Open Font License.

Style/usage notes:

• The help region is not rendered so error/success/debugging/etc. messages not displayed.
• Does not render page control tabs (view/edit/revisions/etc.) so trying to browse and manage content is a bit troublesome.
• Paragraph tags in content have no top/bottom margin so they run together with no vertical spacing to separate them.

Two more:

• theme-settings.php is empty, should it be removed or is there code that is meant to be in this file that just hasn't been added to the codebase yet?
• The main TukTuk library is not GPL licensed code (it's MIT licensed according to the license.md file in the main GitHub repo) I believe that's still GPL-compatible and okay for use on D.o but would want to double-check with someone more in the know.

Edit: A few other discussions around the license used for FontAwesome.

• Github: FontAwesome - SIL Open Font License and GPL #1124
• Drupal.org: Allow OFL and GPL2 +FE Font Licenses
• Drupal.org: Include font-awesome into whitelist?

Please don't Rtbc your own application, see the project application workflow https://drupal.org/node/532400

@jkswoods, I came across these below issues in your .info file(s). Please fix them.

1) 'description' line in your .info file(s) needs to DESCRIBE your theme. It should be "A short description of the theme" - https://drupal.org/node/171205#description

2) In Drupal 7, the line "engine = phptemplate" is no longer necessary because PHPTemplate is assumed by default. - https://drupal.org/node/171205#regions

3) Missing page_top and page_bottom regions in your .info file. "If you define custom regions, it is important to remember that you need to include the page_top and page_bottom regions in your set of regions." - https://drupal.org/update/themes/6/7#closure

Really nice looking theme - would consider using it in the future as would making developing for mobile a breeze.

Few issues I found:

• sidebar_second is not actually rendered in page.tpl.php so any blocks placed there will never appear.
• Whilst page_top and page_bottom are in the info file and html.tpl.php when viewing /admin/structure/block neither the page_top or page_bottom regions appear in the list. They also don't appear on the /admin/structure/block/demo/tuktuk page.
• html.tpl.php, block.tpl.php, comment.tpl.php, maintenance-page.tpl.php and node.tpl.php all have missing semicolons on the ends of lines
• Also pareview is saying you shouldn't have -dev on the end of your git branches and Bad line endings were found in custom.styl and custom.less.

Whilst page_top and page_bottom are in the info file and html.tpl.php when viewing /admin/structure/block neither the page_top or page_bottom regions appear in the list. They also don't appear on the /admin/structure/block/demo/tuktuk page.

page_top and page_bottom are used programmatically for stuff within Drupal not as a region for manual block assignments. Things like the admin toolbar and some modules that add scripts to the page (like some analytics scripts that use a "this goes before the closing BODY tag" scenario) use them.

Ah ha, I did not realise that - good to know.

Here's a quick review. There are still several (100+ issues) to resolve from the PAReview. http://pareview.sh/pareview/httpgitdrupalorgsandboxjkswoods2188627git

What is the info.sub file for? There isn't much information in the README how to use this module. It looks like there is some type of drush integration, how does someone use tuktuk drupal theme?

.info file:
Tabs seem to be used instead of spaces.

.drush.inc
Very limited function comments.

PAReview: 3rd party code

tutuk appears to be 3rd party code. 3rd party code is not generally allowed on Drupal.org and should be deleted. This policy is described in the getting involved handbook. It also appears in the terms and conditions you agreed to when you signed up for Git access, which you may want to re-read, to be sure you're not violating other terms.

The Libraries API module is a recommended method for adding 3rd party dependencies without directly including the code on Drupal.org.

Some licensing issues are raised in #11 with links to a few (of the very many) discussions about third party assets that has taken place in various threads. However, opinions in issue threads are not policy.

I think this is put straight in #25, but I just want to add by two cents worth.

The police is laid down here: Drupal Git Repository Usage policy, and it says:

All files checked into the repository (code and assets) must be licensed under GNU/GPL version 2 and later.

This is pretty clear: If it ain't GPL V2+, it's gotta go.

And further down the page:

A user's account may be terminated without warning for reasons that include, but are not limited to:
1.) violation of these TOS;

That is pretty clear as well: If you violate this TOS, you gotta go.

PS: Looking at the vast amount of non-GPL V2+ assets that currently are hosted at Drupal.org, I get the impression that exceptions are made (if you know the secret handshake or something). But in the PA review project, I think we need to go by the book.

Closing per applicant's request.