Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I've edited the JS file and am ready to upload a patch.
Comment | File | Size | Author |
---|---|---|---|
#12 | tabs-firebug-2.jpg | 56.08 KB | SocialNicheGuru |
#12 | tabs-firebug-1.jpg | 141.75 KB | SocialNicheGuru |
#5 | panels_tabs-2214435-5-make-panels-tabs-linkable.patch | 1.41 KB | geek-merlin |
Comments
Comment #1
patchshorts CreditAttribution: patchshorts commentedComment #2
patchshorts CreditAttribution: patchshorts commentedComment #3
patchshorts CreditAttribution: patchshorts commentedComment #4
SocialNicheGuru CreditAttribution: SocialNicheGuru commentedthe patch no longer applies
Comment #5
geek-merlinRerolled and attributed to original author.
Applies and worksforme.
Please test.
Comment #6
geek-merlinPlease test first.
Comment #7
geek-merlinCorrected version.
Comment #10
SocialNicheGuru CreditAttribution: SocialNicheGuru commentedI get a HUGE number of tabs generated on the page.
Comment #11
boabjohn CreditAttribution: boabjohn commentedHey guys,
Keen to access this sort of functionality...but not keen to have a stack of tabs generated on a production site. @patchshorts have you been able to reproduce @socialnicheguru's problem?
Comment #12
SocialNicheGuru CreditAttribution: SocialNicheGuru commentedSorry, let me elaborate.
I have a mini panel in the main content area where panels_tabs have been applied.
So I understand tabs-0-contentmain-1 for the first tab.
I have only four tabs in the main content area.
But there are a lot of tabs being printed out in firebug.
I'm concerned that the multiple calls to js are a hit to performance.
I have another mini-panel for the sidebar on my page.
Within the sidebar mini-panel is another mini-panel. The latter mini-panel also has panels tabs.
There are three tabs here and only three show up in the UI but multiple show up in firebug (tabs-firebug-2.jpeg)
I do get the number of tabs to show up in firebug.
The UI seems fine. I am just concerned about the multiple calls to javascript and performance.
Please see screen capture below.
Comment #13
SocialNicheGuru CreditAttribution: SocialNicheGuru commentedAlso if I click on the tab, shouldn't it be reflected in the url at the top of the page?
Currently I can cut and paste the tab url but that's it.
Comment #14
SocialNicheGuru CreditAttribution: SocialNicheGuru commentedIn reference to #12:
I think this patch creates links for hidden content panes in mini-panels with tabs or accordion styles.
The issue I have with numerous tabs is more a function of my misunderstanding of how linking works or is it supposed to work this way?
This is a dev machine.
In each of the mini-panels where I have tabs or accordion styles enabled, there are a few content panes that are hidden.
It looks like links are created for these hidden content panes also and thus show up in Firebug.
Should links be created for hidden content panes?
Comment #15
todea CreditAttribution: todea commentedI had to modify the tabs.bind method to get this working in my environment. Also added a line to stop the page from scrolling due to the anchor tags.