Support from Acquia helps fund testing for Drupal Acquia logo

Comments

patchshorts’s picture

Version: 7.x-2.x-dev » 7.x-1.x-dev
patchshorts’s picture

Status: Active » Fixed
FileSize
1.09 KB
patchshorts’s picture

Status: Fixed » Patch (to be ported)
SocialNicheGuru’s picture

Status: Patch (to be ported) » Needs work

the patch no longer applies

geek-merlin’s picture

Status: Needs work » Reviewed & tested by the community
FileSize
1.41 KB

Rerolled and attributed to original author.
Applies and worksforme.
Please test.

geek-merlin’s picture

Status: Reviewed & tested by the community » Needs review

Please test first.

geek-merlin’s picture

Version: 7.x-1.x-dev » 7.x-2.x-dev

Corrected version.

Status: Needs review » Needs work

The last submitted patch, 5: panels_tabs-2214435-5-make-panels-tabs-linkable.patch, failed testing.

Status: Needs work » Needs review
SocialNicheGuru’s picture

I get a HUGE number of tabs generated on the page.

boabjohn’s picture

Hey guys,
Keen to access this sort of functionality...but not keen to have a stack of tabs generated on a production site. @patchshorts have you been able to reproduce @socialnicheguru's problem?

SocialNicheGuru’s picture

FileSize
141.75 KB
56.08 KB

Sorry, let me elaborate.

I have a mini panel in the main content area where panels_tabs have been applied.
So I understand tabs-0-contentmain-1 for the first tab.
I have only four tabs in the main content area.
But there are a lot of tabs being printed out in firebug.
I'm concerned that the multiple calls to js are a hit to performance.

I have another mini-panel for the sidebar on my page.
Within the sidebar mini-panel is another mini-panel. The latter mini-panel also has panels tabs.
There are three tabs here and only three show up in the UI but multiple show up in firebug (tabs-firebug-2.jpeg)

I do get the number of tabs to show up in firebug.

The UI seems fine. I am just concerned about the multiple calls to javascript and performance.

Please see screen capture below.

SocialNicheGuru’s picture

Also if I click on the tab, shouldn't it be reflected in the url at the top of the page?
Currently I can cut and paste the tab url but that's it.

SocialNicheGuru’s picture

In reference to #12:

I think this patch creates links for hidden content panes in mini-panels with tabs or accordion styles.

The issue I have with numerous tabs is more a function of my misunderstanding of how linking works or is it supposed to work this way?

This is a dev machine.
In each of the mini-panels where I have tabs or accordion styles enabled, there are a few content panes that are hidden.

It looks like links are created for these hidden content panes also and thus show up in Firebug.

Should links be created for hidden content panes?

todea’s picture

I had to modify the tabs.bind method to get this working in my environment. Also added a line to stop the page from scrolling due to the anchor tags.

tabs.bind('tabsactivate', function (event, ui) { //when tab is shown update the URL
        var url = document.location.toString();
	var scrollTop = $(window).scrollTop();
        document.location.hash = ui.newPanel.attr('id');
	$(window).scrollTop(scrollTop); // keep scroll at current position
});