[D7] Gravatar Favicon

Hello,

Seems like you can check the pareview.sh output, there is some formatting that could be fixed.

PAReview still comes up with some notes about your Git repository structure:

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

I took a look through the code and i think there's a glitch to your logic in your if() statements on line 49 and 69. Right now they check for "is theme_get_setting for 'toggle favicon' true?" which is only the case when you have the default favicon enabled. Right now trying to use the settings in a fresh install doesn't appear to do anything. When I tried flipping those from...

if (theme_get_setting('toggle_favicon') && /* ... */

...to...

if (!theme_get_setting('toggle_favicon') && /* ... */

...everything worked as intended.

You should add the folder name to clone to into your Git stuff in your initial post (this assumes you make the branch changes mentioned above as well to move from master to a 7.x-1.x branch in keeping with the d.o project guidelines)...

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/drashmk/2214517.git gravatar_favicon

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Looks like a debugging statement got left in place.

Fatal error: Call to undefined function dd() in /Users/mraichelson/Desktop/project_review/sites/all/modules/gravatar_favicon/gravatar_favicon.module on line 70

(With that said: once that line is commented out everything looks good to me.)

Works peachy for me.

Automated Review

Clean: No errors found. Please add this link of the automated review results to the issue description: http://pareview.sh/pareview/httpgitdrupalorgsandboxdrashmk2214517git

Manual Review

Individual user account

Yes.

No duplication

Yes. Found some modules that add different-sized icons (https://www.drupal.org/project/touch_icons, https://www.drupal.org/sandbox/tomtech/2208791) but they don't work with Gravatar.

Master Branch

Absent (which is good). But please change the 'git clone' command at the issue description.

Licensing

Absent (which is good).

3rd party code

Absent (which is good).

README.txt

Yes. Though some text formatting would be ideal. (You can refer to README Template docs.)

Code too short

Unfortunately this project is too short to approve you as git vetted user. There are a discussion about how much code should be at the full project, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed. However, git administrators can promote this single project manually to a full project for you.

Secure code

Yes.

Coding style & Drupal API usage

No big issues found.

Forgot to add a tag.

Duplication

This sounds like a feature that should live in the existing Gravatar integration project. Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. Please open an issue in the Gravatar integration issue queue to discuss what you need. You should also get in contact with the maintainer(s) to offer your help to move the project forward. If you cannot reach the maintainer(s) please follow the abandoned project process.

If that fails for whatever reason or you disagree with this decision please get back to us and set this back to "needs review".

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.