Is the page, admin/config/development/modernizr, telling me that the tests are now installed? Why doesn't it change after I uploaded the custom build?

on admin/config/development/modernizr I get a list of tests

here is the abridged version:
Current Modernizr Tests
Currently enabled Drupal modules and themes have requested the following Modernizr tests:

cssclasses - Allows Modernizr to inject CSS classes into
printshiv - Provides html5shiv (for browsers that do not support HTML5 tags). Support for printing.
load - Provides yepnope.js, an asynchronous CSS/JS loader that allows use of Modernizr.load
cssanimations - CSS property that allows for keyframe-based animations.
csstransitions - CSS property that allow other CSS properties to smoothly tween between two values.
applicationcache - Browser cache layer that allows for offline usage of web applications.
canvasJavaScript - API that allows for dynamic, scriptable rendering of 2D shapes and bitmap images

I do a custom build, modernizer-xxxxxxx.js
place the custom build in sites/libraries/modernizr
clear cache
When I go back to the page I get the same list of tests.

On status page, admin/reports/status Modernizr status is green and the version is 2.7.1

Comments

rupl’s picture

rupl
he/him
Primary language English
CreditAttribution: rupl commented
Status: Active » Postponed (maintainer needs more info)

Please follow the instruction on submitting support requests and include the custom build URL in your Modernizr JS file. I cannot properly help until you provide that info.

To see instructions for this, look at the big green box labeled "Support requests" on the create issue page

SocialNicheGuru’s picture

SocialNicheGuru CreditAttribution: SocialNicheGuru commented
Status: Postponed (maintainer needs more info) » Active 
http://www.modernizr.com/download/#-cssclasses-printshiv-load-cssanimations-csstransitions-applicationcache-canvas-canvastext-draganddrop-hashchange-history-audio-video-indexeddb-input-inputtypes-localstorage-postmessage-sessionstorage-websockets-websqldatabase-webworkers-geolocation-inlinesvg-smil-svg-touch-webgl-shiv-mq-addtest-prefixed-teststyles-testprop-testallprops-hasevent-prefixes-domprefixes

Also on drupal.org/project/modernizr it says that it should be renamed to modernizr.min.js but in the module it looks for modernizer.xxxx.js. Is that significant?

rupl’s picture

rupl
he/him
Primary language English
CreditAttribution: rupl commented

Thanks for the link. I downloaded your custom build and unfortunately I cannot reproduce the issue. My admin screen shows the full list. The only hunch I have at the moment is that you listed "sites/libraries/modernizr" as the location of your JS lib — did you place the library in "sites/all/libraries/modernizr" or "sites/libraries/modernizr"?

The file name should not make a difference. Just to make sure I renamed your custom build to modernizr.xxxxx.js, modernizr-xxxxx.js, and modernizr.min.js and they all work.

SocialNicheGuru’s picture

SocialNicheGuru CreditAttribution: SocialNicheGuru commented

ok maybe I am misinterpreting the list.

on the admin page it gives a long list.
When I upload the library should it still be showing the long list?
On the page should it say that these tests have been included in the uploaded library so that I know that it works?

rupl’s picture

rupl
he/him
Primary language English
CreditAttribution: rupl commented
Related issues: +#1569398: "Download Modernizr" link on the settings page should include all tests currently within the JS file, +#2023387: Modernizr API should publicly expose the list of tests found within active library, +#2217433: Rebuild Modernizr page should indicate which tests are already in custom build

Yes, all tests that are in your current file should be in the list, including when you download a new copy of Modernizr. I might have gotten confused because in your initial report you mention an "abridged version" of the page.. did you remove a portion of the list in your report?

Here's the issue which added items from modernizr.js into the admin listing: #1569398: "Download Modernizr" link on the settings page should include all tests currently within the JS file

However, I have been meaning to add an indicator that a particular test is already inside your build of Modernizr. Here are some issues to track this feature:

So just to confirm: is Modernizr module/library working as you want it to? Even though the admin UI caused confusion?

SocialNicheGuru’s picture

SocialNicheGuru CreditAttribution: SocialNicheGuru commented

yeah it seems to be.

I am sorry to have caused such a ruckus. It looks like this was more of a documentation issue than anything else.

it would be nice to place in the Readme if you can say that:

1. the downloaded file can be modernizr-xxxx.js. On the project page it says modernizer.min.js and I am not sure if that works too.

2. that the admin page lists all the tests that should be uploaded via the custom link. Check admin/reports/status to see if there are any problems with the modernizr install.

Thanks again for being so helpful today!

rupl’s picture

rupl
he/him
Primary language English
CreditAttribution: rupl commented
Title: Uploaded new library but no change on admin page - cache is cleared! » Uploaded new library but no change on admin page
Component: Code » Documentation

No problem! It's helpful for me to hear feedback on how you interpret the UI. I'm just wingin' it :)

Issue marked as docs.

rupl’s picture

rupl
he/him
Primary language English
CreditAttribution: rupl commented
Status: Active » Closed (fixed)

I believe all the issues I recently committed to dev will clear up the module's confusing UI. Thanks once again for the feedback. It really helped me understand how to make the UI less confusing.

zarabatana’s picture

zarabatana CreditAttribution: zarabatana commented

Comment #3 make it work.
Thanks