Similar to #2054113, when acquia_agent_check_subscription() calls acquia_agent_get_subscription() which calls acquia_agent_valid_response() and fails validation it will mean that the variable acquia_subscription_data will lose any stored subscription data.

Acquia Agent should leave stored data in place, perhaps just updating a property within.

CommentFileSizeAuthor
#1 2217311-acquia-agent-hmac-invalid.patch1.04 KBcoltrane
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

coltrane’s picture

coltrane
he/him
CreditAttribution: coltrane commented
Status: Active » Needs review
FileSize
2217311-acquia-agent-hmac-invalid.patch1.04 KB

Attached patch returns the current stored subscription data if the server responded with an HMAC validation error. The theory being that in the event of an invalid response the data should not be trusted to be used by modules invoking 'acquia_subscription_status'. In practice I think most validation errors are temporary glitches so it's fine to skip doing anything during this subscription check.

arnested’s picture

arnested CreditAttribution: arnested commented

The patch looks very promising.

From studying the code I'll say this is fine!

I'll look deeper into it and test it out tomorrow and then probably RTBC on monday.

arnested’s picture

arnested CreditAttribution: arnested commented
Status: Needs review » Reviewed & tested by the community

  • Commit eb1165d on 7.x-2.x by coltrane: 
    Issue #2217311 by coltrane: Do not delete subscription data when hash...
coltrane’s picture

coltrane
he/him
CreditAttribution: coltrane commented
Status: Reviewed & tested by the community » Fixed

Fixed. Thanks for review @arnested.

  • Commit fc89b82 on 6.x-2.x by coltrane: 
    Issue #2217311 by coltrane: Do not delete subscription data when hash...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.