I've just realized these are ambiguous:

 * When called during a flagging or unflagging (such as from a hook
 * implementation or from Rules), the flagging or unflagging that is in the
 * process of being performed:
 *  - will be included during a flagging operation
 *  - will NOT be included during an unflagging operation.
 * implementation or from Rules), the count this returns will include the
 * flagging or unflagging that is in the process of being performed.

Does 'NOT be included' in a count mean the count WON'T count it, because it's not included?

Does 'included in a count' mean it's still being counted?

That's not actually what I meant when I wrote this! I meant the exact opposite! 'not included' means the fact that it's removed isn't considered. So it's still counted.

AAAARGH. Will fix.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

shabana.navas’s picture

Hmm, I actually understood it, probably because I knew before hand what it was supposed to mean. I might need to change the Rules UI docs, too.

joachim’s picture

It's ok, I was partway through reviewing your patch and making a few tweaks when I noticed this.

joachim’s picture

Status: Active » Needs review
FileSize
3.42 KB
shabana.navas’s picture

Status: Needs review » Reviewed & tested by the community
joachim’s picture

Status: Reviewed & tested by the community » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.