Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I've just realized these are ambiguous:
* When called during a flagging or unflagging (such as from a hook
* implementation or from Rules), the flagging or unflagging that is in the
* process of being performed:
* - will be included during a flagging operation
* - will NOT be included during an unflagging operation.
* implementation or from Rules), the count this returns will include the
* flagging or unflagging that is in the process of being performed.
Does 'NOT be included' in a count mean the count WON'T count it, because it's not included?
Does 'included in a count' mean it's still being counted?
That's not actually what I meant when I wrote this! I meant the exact opposite! 'not included' means the fact that it's removed isn't considered. So it's still counted.
AAAARGH. Will fix.
Comment | File | Size | Author |
---|---|---|---|
#3 | 2217487.flag_.ambiguous-count-docs.patch | 3.42 KB | joachim |
Comments
Comment #1
shabana.navas CreditAttribution: shabana.navas commentedHmm, I actually understood it, probably because I knew before hand what it was supposed to mean. I might need to change the Rules UI docs, too.
Comment #2
joachim CreditAttribution: joachim commentedIt's ok, I was partway through reviewing your patch and making a few tweaks when I noticed this.
Comment #3
joachim CreditAttribution: joachim commentedComment #4
shabana.navas CreditAttribution: shabana.navas commentedComment #5
joachim CreditAttribution: joachim commentedThanks!