Needs review
Project:
OAuth 1.0
Version:
7.x-3.2
Component:
Code
Priority:
Major
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
16 Mar 2014 at 02:20 UTC
Updated:
6 Jun 2014 at 21:28 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
brettsh commentedComment #2
froboyThis is indeed an issue. I don't want to get into/start a curl/drupal_http_request debate, but I think I've worked up a fix that should solve the issue while still using curl. I'm grabbing the proxy variables that drupal_http_request would use but then setting curl to use them via CURLOPT_PROXY. Check it out.
Comment #3
zaphoyd commentedI can confirm that OAuth 7.x-3.2 does not work on backend machines behind a firewall that must communicate externally through a proxy. This issue in turn breaks all modules that rely on OAuth for authenticating requests to external servers.
I've tested the patch in #2 and it has been running happily in our production environment, which requires a forward proxy for all outbound traffic, for a few weeks. This patch uses the standard proxy variables that D7 core uses and is minimally invasive to the rest of the code (does nothing unless said proxy variables are set).
Comment #4
zaphoyd commentedLinking to an older issue with a slightly different patch that uses drupal_http_request. I think the drupal_http_request method is better in the absence of any particular guidance from the maintainers on why cURL. That said, both are reasonable options and either would be preferable to nothing.