Notices everywhere when using custom widgets

Fixed paths.

Maybe you got me wrong there.
It was not my intention to be rude, but I was annoyed by the the notices.

Whatsoever: I'm sorry.

The following is not intended to be rude, but is kept short, because it is much.

The "code more carefully" thing is something, that is not Drupal specific. It's a general thing. Default variables are used to spare all the "isset()" calls in the upcoming function body.
I did not want to hurt any feelings there, it was just the second time, a similar error ooccured in a row. And since we are using this in corporate environment we are held to stick to the code that comes from the modules directly to keep it updateable. No forks etc. in any way if we can get around it somehow.

Thanks for the tip with the dev version and the testing. Any idea, why this is happening?
What if there is no dev version?

Regarding the notices:

"a huge amount of notices" - tens, hundreds, thousands, millions, … ? Please quantify "huge". What notices? Please give examples.

Notice: Undefined index: allow_revote in fivestar_custom_widget() (Zeile 448 von /drupalroot/docroot/sites/all/modules/contrib/fivestar/fivestar.module).
    Notice: Undefined index: allow_ownvote in fivestar_custom_widget() (Zeile 449 von /drupalroot/docroot/sites/all/modules/contrib/fivestar/fivestar.module).
    Notice: Undefined index: description in fivestar_custom_widget() (Zeile 454 von /drupalroot/docroot/sites/all/modules/contrib/fivestar/fivestar.module).
    Notice: Undefined index: stars in fivestar_custom_widget() (Zeile 445 von /drupalroot/docroot/sites/all/modules/contrib/fivestar/fivestar.module).
    Notice: Undefined index: allow_revote in fivestar_custom_widget() (Zeile 448 von /drupalroot/docroot/sites/all/modules/contrib/fivestar/fivestar.module).
    Notice: Undefined index: allow_ownvote in fivestar_custom_widget() (Zeile 449 von /drupalroot/docroot/sites/all/modules/contrib/fivestar/fivestar.module).
    Notice: Undefined index: description in fivestar_custom_widget() (Zeile 454 von /drupalroot/docroot/sites/all/modules/contrib/fivestar/fivestar.module).
    Warning: Division by zero in _fivestar_get_element_default_value() (Zeile 745 von /drupalroot/docroot/sites/all/modules/contrib/fivestar/fivestar.module).
    Warning: Division by zero in _fivestar_get_element_default_value() (Zeile 746 von /drupalroot/docroot/sites/all/modules/contrib/fivestar/fivestar.module).

Here are a few.
I know, why those are happening.
I am using the fivestar_custom_widget() function directly in a pane without rendering the field.
So the problem is, that indexes like 'allow_ownvote' are not set in my call of the function.
Since I do not want to set the manually everytime I use the function, I want them to fall back to the defaults.

So this is where the problem begins. There are not defaults for it.
You are checking for not set indexes already for some indexes, like here:

function fivestar_custom_widget() {
...

'#auto_submit' => isset($settings['autosubmit']) ? $settings['autosubmit'] : TRUE,
....

But you did not do this for the new indexes.

Since it is kind of annoying to check this all over the function again and again I put in a default array, which holds the defaults in one place. You could even write a function for it which alters given variables if you would want to use it somewhere else, too.

The warnings at the end could be avoided by a simple if to check if the stars value is at all set and is a positive integer.

Huge amount means briefly every time I call this fivestar_custom_widget() function, which is on every node page having 200k+ nodes and a lot of visitors, google, testing.... So I can not exactly say how much there are, but you get the picture ^^

"it seems like you fixed one description notice (after a long time), but brought like 3-4 new ones per request." - what was the one fixed? How long is a long time? What do you mean by "request"?

By "long time" no fix I meant between 2012 and 2014. Nothing happened there. I do not know, if it was reported though, but nevertheless, no stable. I know this is open source and community driven etc. I am just saying this, because you asked.
The notices which is now fixed is in `fivestar.module`:~504

Now containing this:

$form['vote']['vote']['#description'] = isset($new_element['vote']['#description']) ? $new_element['vote']['#description'] : '';

Was:

$form['vote']['vote']['#description'] = $new_element['vote']['#description'];

Request = every time I open a page with the Fivestar custom widget included. Or for the old problem, that was fixed if it was submitted.

"missing documentation" - do feel free to update the documentation. Those two options are pretty straightforward.

Even if they are, like you say "straight forward", you always say even some words to it. No one can now say, where those things take effect, what exactly they are doing and when.
I know there is no such specific rule in the Drupal Coding Conventions, but I am pretty sure, you can put this one under "document your function parameters".
Drupal itself is badly documented at most parts. If you compare it to stuff like CakePHP (which is not a CMS, I know) it is the worst and nothing more than an API. I think the community should be a role model for Drupal instead of the other way round.
I would write it, but I rather like you to do it, because you can do it faster and more accurate than me, who has to check all the code for exact functionality.

Sorry, for the late answer. Did not get an email or something. I have to check my notifications.

Regards
func0der

--- EDIT:

I forgot: I ran the updates.

No update on this one?

Okay...now you have to be kidding me.

You asked me what I mean by "long" and now you have not answered in this "direct" conversation for over 2 months?

Hello?