Hello,

I find when get a stream wrapper external url, there is lost http: in the first.

the url is:

//canfiles.s3.amazonaws.com/domain/19/logo_Google_small_0.png

Which make the email don't load the image.

Please review this picture.

CommentFileSizeAuthor
#1 extenal_url_lost_http-2222775.patch534 byteslixiphp
email_content_url_image.png34.87 KBlixiphp

Comments

lixiphp’s picture

lixiphp commented
StatusFileSize
new extenal_url_lost_http-2222775.patch534 bytes

I have upload the patch to solve this issue.

Please review that.

Thanks.

justafish’s picture

justafish
she/her
Primary language English
Location London, UK
commented
Status: Needs review » Closed (won't fix)

That's on purpose, it matches the current protocol of the page being looked at. I'm not exactly sure what you're trying to do with e-mail, but you could preprocess it and add the appropriate prefix.

http://www.paulirish.com/2010/the-protocol-relative-url/

dlumberg’s picture

dlumberg commented

This is also breaking fully qualified URLs in MRSS feeds. We're getting:

<media:content url="///subdomain.s3.amazonaws.com/videos/127065/English_Introduction_Video_mp4hd_1399576204.mp4" />

note the ///

I can confirm that the patch in #1 fixes the issue for us but there must be a way to accomplish the relative url protocol that doesn't break the "Link video to file" method in views using the video module.

vanvemden’s picture

vanvemden
Location San Francisco
commented

Same issue here; was getting URLs like: ///bucket.s3.amazonaws.com/path/to/file/....
In IE the link URLs ended up as http://example.com///bucket.s3.amazonaws.com/path/to/file/... which made the links not work.
Patch fixed the issue for me. Thanks! This one gave me a headache!

griz’s picture

griz commented

I'm using commerce_file and I also get links lacking their protocol (which obviously don't work).

davidtrainer’s picture

davidtrainer commented
Status: Closed (won't fix) » Reviewed & tested by the community

Hi, I encountered this issue on a website for a client wanting to publish a podcast, using an audio field and the Views RSS module. The problem, as others have mentioned, is that the protocol-relative URL does not work in the context of an xml+rss feed.

This took me a while to troubleshoot because the module does not behave as described in its own comments:

  /**
   * Returns a web accessible URL for the resource.
   *
   * In the format http://mybucket.amazons3.com/myfile.jpg

So I think this is clearly a bug. I reviewed and successfully applied the patch in #1, so marking RTBC.

justafish’s picture

justafish
she/her
Primary language English
Location London, UK
commented

Fixed in #2401101: Fix the external URL generation

justafish’s picture

justafish
she/her
Primary language English
Location London, UK
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.