After some of the recent updates, it looks like og is throwing errors on the user profile edit pages. See attached screenshot for more.

I've verified this happens on a completely stock new install of commons without any patches, other than what comes with the make file.

CommentFileSizeAuthor
#10 2225889-realname-correct-menu-10.patch3.63 KBfenstrat
#4 2225889-realname-correct-menu-3.patch3.65 KBjaperry
#1 2225889-realname-correct-menu-2.patch3.63 KBjaperry
Screenshot_3_25_14_1_03_PM-2.png192.89 KBjaperry

Comments

japerry’s picture

japerry
Location KOMK
commented
Project: Drupal Commons » Real Name
Version: 7.x-3.x-dev » 7.x-1.x-dev
Status: Active » Needs review
Issue tags: +commonslove
StatusFileSize
new 2225889-realname-correct-menu-2.patch3.63 KB

Further investigation from the last comment in #1722112: Autocomplete for entityreference fields reveals that the code replaces the functionality of the entityreference module, but doesn't confirm to the API entityreference uses.

This causes other modules that rely on altering entity reference autocomplete to fail. The patch below fixes that by bringing the menu callbacks in line with what entity reference uses.

You can reproduce by enabling OG adding a user group reference. (or just use the latest commons dev snapshot, which includes the newest version of realname)

scottzak’s picture

scottzak commented

Applying this patch breaks og_ui_add_users form. This was working in Commons 3.9 and no longer works in 3.11. When I undo the patch it begins working again. We're not using trusted contacts, so we don't encounter the original issue (if I understand the issue correctly).

hass’s picture

hass commented
Status: Needs review » Needs work
japerry’s picture

japerry
Location KOMK
commented
Status: Needs work » Needs review
StatusFileSize
new 2225889-realname-correct-menu-3.patch3.65 KB

Try this patch out, it should work better with OG and user reference callbacks.

scottzak’s picture

scottzak commented

Thank you very much for working on this. I'll give it a good look.

eacute’s picture

eacute commented

I confirm that the patch #3 fix the problem with commons 3.13

scottzak’s picture

scottzak commented

Patch #3 seems to solve the problem for me. Thanks again!

hass’s picture

hass commented
Status: Needs review » Needs work
Issue tags: +Needs tests
yepa’s picture

yepa
he/him
Primary language French
Location Geneva
commented
Status: Needs work » Needs review

Patch #3 remove notices.

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented
StatusFileSize
new 2225889-realname-correct-menu-10.patch3.63 KB

Reroll of #4.