[D7] USAJobs

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

A lot of HTML inside hook_block_view().

  $item  = '<div class="job-title">';
      $item .= '<a href="' . $job->url . '" target="_blank">' . check_plain($job->position_title) . '</a>';
      $item .= '</div>';

you can implement hook_theme() / have a seperate template for handling a lot of markup stuff.

Could not find any major issues, however the addition of some css to format the job listing would make the block look prettier out the box.

This is only a suggestion, not a bug, but selecting the organization ID isn't very user friendly. Would it be possible to have one drop down to select state and one to select organization (this may not be practical but would be nice...)

Looks good with the new CSS.

Still can't spot any other issues so got the thumbs up from me.

manual review:

1. usajobs_block_view(): no need to use #markup here, you can just build a nested render array with _usajobs_block_content(). Then you also don't have to call theme() in _usajobs_block_content() and other modules can better alter the block render array if they want to.
2. usajobs-item.tpl.php: "Apply by print $job_end_date; " should run through t() for translation.

But otherwise looks good to me, so ...

Thanks for your contribution, phoang!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.