Needs work
Project:
Drupal core
Version:
main
Component:
markup
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
1 Apr 2014 at 16:14 UTC
Updated:
16 Jul 2025 at 18:47 UTC
Jump to comment: Most recent
Problem/Motivation
String::placeholder used everywhere in Drupal (it added Italic style to texts). It's poor readability. Sometimes, I feel it's a historic mistake. Developers copying the code style and unintended to use String::placeholder on drupal coding repeatedly...
It's more worse results in non-English, e.g., in Chinese:
Should it always use Italic only?
Example:
admin/config/people/accounts
A: Italic
Leave empty to use the default system e-mail address (kay@example.com).
B: Bold
Leave empty to use the default system e-mail address (kay@example.com).
Proposed resolution
-
Remaining tasks
- Decide when to use Italic style
- Introduce specified CSS rules to different language system ( [lang="zh-hant"] { font-style: normal; font-weight: bold } )
User interface changes
- font style
API changes
-
Issue fork drupal-2230689
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 2230689-remove-redundant-italic
changes, plain diff MR !4792 - 2230689-11 changes, plain diff MR !5965
Comments
Comment #1
droplet commentedComment #2
lewisnymanComment #3
olemedia commentedI would like to suggest to just remove the italic all together since does not make any difference. I strongly believe that with with the current gray color font and with the current font size is enough to understand that the text is instructional only.
Comment #18
gauravvvv commentedComment #19
smustgrave commentedMR should be 11.x
Also not sure about this one, have you checked anywhere else on the site it's being used?
Remaining tasks say
- Decide when to use Italic style
- Introduce specified CSS rules to different language system ( [lang="zh-hant"] { font-style: normal; font-weight: bold } )
Comment #20
bhumikavarshney commentedHi droplet,
As smustgrave mentioned can you please suggest where we need to use italics font or do we need to remove for the help text added for the field or we need to do it for language specific so accordingly we can do the changes.
Thank You!
Comment #21
bhumikavarshney commentedComment #22
gauravvvv commentedComment #25
markconroy commentedCan we get the MR for this updated. The current one says it has over 1,500 commits to it. I doubt we did that much work to this issue :)
Looking at the specific example from the account settings form, the
<em>is only around the email address and not the text.'#description' => $this->t("The email address to be used as the 'from' address for all account notifications listed below. If <em>'Visitors, but administrator approval is required'</em> is selected above, a notification email will also be sent to this address for any new registrations. Leave empty to use the default system email address <em>(%site-email).</em>", ['%site-email' => $site_config->get('mail')]),If this is still an issue, let's get a list of where we need to change it so we can work on it.