Particularly for this issue:

- Context produces some notices:
Notice: Undefined property: stdClass::$content in _block_get_renderable_array()

I would like to submit a patch to work around the context bug.

CommentFileSizeAuthor
#5 ultimenu-fix_context_undefined_property-2233215-5-diff_from_prev_commit.patch874 bytesquintux
#5 ultimenu-fix_context_undefined_property-2233215-5.patch1.71 KBquintux
#1 ultimenu-fix_context_undefined_property-2233215-1.patch1.33 KBquintux

Comments

quintux’s picture

quintux commented
Status: Active » Needs review
StatusFileSize
new ultimenu-fix_context_undefined_property-2233215-1.patch1.33 KB

Attached please have the patch file.

I am not sure if it will be any performance impact. More tests are welcome.
Thanks very much.

  • Commit 9d8f80b on 7.x-1.x authored by quintux, committed by gausarts: 
    Issue #2233215 by quintux: Fixed Notice: Undefined property: stdClass::$...
gausarts’s picture

gausarts commented
Status: Needs review » Fixed

That is great, thank a lot.

quintux’s picture

quintux commented
Status: Fixed » Closed (fixed)

@gausarts,
Thank you.

quintux’s picture

quintux commented
Status: Closed (fixed) » Needs review
StatusFileSize
new ultimenu-fix_context_undefined_property-2233215-5.patch1.71 KB
new ultimenu-fix_context_undefined_property-2233215-5-diff_from_prev_commit.patch874 bytes

Hi @gausarts,

Sorry to bring this up again.

I find a better way to prepare the block contents by using the _block_render_blocks() function which has better cache handling.
The code is much cleaner, too.

gausarts’s picture

gausarts commented

Yup, much cleaner. Will commit after a few more test. Thanks again.

  • Commit 65a2c41 on 7.x-1.x authored by quintux, committed by gausarts: 
    Issue #2233215 by quintux: Fixed Notice: Undefined property: stdClass::$...
gausarts’s picture

gausarts commented
Status: Needs review » Fixed

Committed the fix. Thanks a lot for the improvement.

quintux’s picture

quintux commented
Status: Fixed » Closed (fixed)

Thank you.