Closed (fixed)
Project:
Tcmb
Version:
8.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
4 Apr 2014 at 13:21 UTC
Updated:
3 May 2014 at 09:10 UTC
Jump to comment: Most recent, Most recent file
.menu_links.yml and .routing.yml should be updated to make settings show in /admin/config/system.
Currently, it doesn't show.
I studied http://drupalcode.org/project/drupal.git/blob/HEAD:/core/modules/system/... and http://drupalcode.org/project/drupal.git/blob/HEAD:/core/modules/system/... but no luck yet.
Related to
core issue: #2226903: Step 1: Move static menu links to yml files
and change record: hook_menu_link_defaults() moved to *.menu_links.yml files
| Comment | File | Size | Author |
|---|---|---|---|
| #16 | menu_links-2233369-15.patch | 3.52 KB | kartagis |
| #12 | menu_links-2233369-12.patch | 4.66 KB | jessebeach |
| #9 | update_menu_links.yml-2233369-9.patch | 2.79 KB | kartagis |
| #7 | tcmb-new.patch | 4.05 KB | kartagis |
| #3 | tcmb.patch | 5.45 KB | kartagis |
Comments
Comment #2
kartagisComment #3
kartagisProperly indented patch attached.
Comment #4
kartagisComment #5
yesct commentedchanges to
look unrelated. that might be separate clean up and distracting from identifying the problem of getting the settings to show in the admin menu.
--
added links to the change record and core issue in the issue summary.
--
before that core issue went in, did it show in /admin/config/system ? when it was using hood_menu_link_defaults() ?
Comment #6
kartagisIt did, right before parent routes were renamed. At least timplunkett told me they were renamed.
Comment #7
kartagisAdding patch which contains the .menu_links.yml and doesn't contain any of the files under lib/
Comment #9
kartagisAttaching new patch.
Comment #10
yesct commentedNotes from irc:
so you took out hook_menu_links_defaults() ... and changes some route id names in routing.yml
http://drupalcode.org/project/tcmb.git/blob/HEAD:/tcmb.routing.yml
and the "page" /admin/config/system/tcmb-settings loads
what about local tasks or menu links...
http://drupalcode.org/project/tcmb.git/blob/HEAD:/tcmb.local_tasks.yml
it is in the title of the issue :) Update .menu_links.yml and .routing.yml to make settings show in /admin/config/system
and the base_route and parent_id stuff there doesn't seem quite correct.
change record you linked to is https://drupal.org/node/2228089
https://drupal.org/node/2228089 => hook_menu_link_defaults() moved to *.menu_links.yml files => 0 comments, 6 IRC mentions
and since you removed those hooks, that title implies you would have had to created a menu_links.yml
so, take a look at both the local tasks and the menu links yml s
https://drupal.org/node/2165273 might be helpful also
https://drupal.org/node/2165273 => Improved DX and altered keys for local tasks definitions => 0 comments, 3 IRC mentions
Comment #11
jessebeach commentedI can't get the links to load either. Looking into this further.
Comment #12
jessebeach commentedI've at least got some of the menu links appearing in the
/admin/config/systempath. It seems there are some clashes and mismatches between routes, menu_links and local_tasks IDs.Comment #13
yesct commentedComment #15
kartagisRerolling
Comment #16
kartagisForgot to add the patch.
Comment #17
kartagisThe .yml files were updated in accordance with the API.
Comment #18
yesct commented@Kartagis Please summarize in words what you had to do.
Also, please give your thoughts on what was missing form the change records that made it difficult to know what changes you had to make.
I think we should be able to improve the docs so that other module developers can have an improved experience.