[D7] UserBallot integration

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxuserballot2234213git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

This is actually pretty neat!

It definitely seems to work and *I don't see any issues with the php

After a few questions popped up and I responded, the popups stopped showing up!

It is unclear to me whether this has to do with my userballot account settings, or the javascript...

Hi.

It's better to move userballot_admin_settings_form() to separate userballot.admin.inc file.
So module code will be:

  $items['admin/config/content/userballot'] = array(
    'title' => 'UserBallot config',
    'description' => 'Configuration for the UserBallot module',
    'page callback' => 'drupal_get_form',
    'page arguments' => array('userballot_admin_settings_form'),
    'access arguments' => array('administer site configuration'),
    'file' => 'userballot.admin.inc',
    'type' => MENU_NORMAL_ITEM,
  );

That point alone is surely not an application blocker, any other problems you found during your review? If not then the correct status should be RTBC.

Automated Review

The automated review of your project by PAReview has found some issues with your code. As coding standards make sure projects are coded in a consistent style we ask you to please have a look at the report and try to fix them. (They all look trivial to fix.)

Manual Review

Individual user account

No: It seems you are using a non-individual account.
All user accounts are for individuals. Accounts created for more than one user or those using anonymous mail services will be blocked when discovered (see Get a Drupal.org account).
Please note that organization accounts cannot be approved for git commit access. See Infrastructure to support organization accounts and Create Basis for ToS to allow organizations to share accounts for details on what is/isn't allowed. Please update your user profile so that we don't have to assume that this is a group account.

No duplication

Yes

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements

3rd party code/content

Yes: Follows the guidelines for 3rd party code.

README.txt

No: For instance there is a setting "Show on admin pages". It is not explained in README.txt what this does. It also looks like a Troubleshooting section could be useful. Also see #7, which looks like a FAQ.

Please take a moment to make your README.txt follow the guidelines for in-project documentation and the README.txt Template.

Code long/complex enough for review

No: The project is only 69 lines of PHP code (after stripping comments and blanks).
It is basically a front end facing a very basic web service (Yes/no questions only - no multiple choice or test answers).
In its current shape, is also very brittle. I rapidly ended up in a state where the webservice did not work, with no diagnostics and no controls that could fix things.
Unless its UX can be significantly improved, it does not deserve to be hosted on Drupal.org as a full project, but belongs in a sandbox.
IMHO it does not follow the guidelines for project length and complexity.
A larger and more complex project should have been submitted for review to apply for the "Create Full Projects" permission. (But I shall leave it to a more senior reviewer to make a final call on this.).

Secure code

Yes: Follows guidelines for writing secure code. (There isn't much to review, but I didn't find anything wrong with the code submitted.)

Coding style & Drupal API usage

(*) All variables defined by your module need to be removed in hook_uninstall(). Please check all your variables.

When entering the Site ID an invalid key is silently accepted (but this obviously stops the module from working). It had been better if there was an error message when an invalid Site ID is entered.

Almost all configuration is supposed to take place at https://app.userballot.com/#/admin. For me, this URL just leads to a page where all settings strings where empty and nothing works.

(*) Currently it is too brittle to become a full project. AFAIK, I didn't do any extraordinary actions before I ended up in limbo with no access to the remote settings. I just poked around to get the "feel" of the project.

The starred items (*) are fairly big issues and warrant going back to Needs Work. The rest of the comments in the code walkthrough are recommendations.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.