Hi,

This is my first Drupal Module. I have tried to go through all steps but it could be that I missed something. So, please help me if I missed anything.

This is a very simple module that I created for my site (after trying to look for something in Drupal) and thought I should release it as a contribution and to see how module submission process goes. I plan to contribute more modules in the future (or join some other module as maintainer).

Thanks

Project Description:

Custom Links module allows users to create custom links and assign those to category. These links will show up in list format in Custom Links blocks.

That block can be used anywhere but mostly it can be used in dashboard to create admin links. Although, this will use normal paths, it will allow users to add custom queries in the links for modules like pre-populate or other needs.

One example is link to Node Add page but with custom parameters.

Project page:
https://drupal.org/sandbox/jrattanpal/2235279

To clone the repo:

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/jrattanpal/2235279.git customize_links
cd custom_links

Comments

jrattanpal’s picture

jrattanpal commented
Title: Custom Links » [D7] Custom Links
mraichelson’s picture

mraichelson commented

A couple quick early-on process notes:

  • You'll need to switch your code from the master branch to using a 7.x-1.x branch (then delete the master branch). More information here: Moving from a master to a major version branch.
  • The checkout instructions in your initial post should be switched over to using the 7.x-1.x branch and the address used for non-maintainers: git clone --branch 7.x-1.x http://git.drupal.org/sandbox/jrattanpal/2235279.git custom_links
  • It looks like the custom_links project namespace is already taken by an existing module: https://drupal.org/project/custom_links.
  • You'll want to take a look at the PAreview.sh automatic review for coding style stuff: PAreview.sh output for your Git repo (you use the "Repeat Review" tab on there to get updated test results after pushing updates).
jrattanpal’s picture

jrattanpal commented
Title: [D7] Custom Links » [D7] Customize Links
Issue summary: View changes

Changed branch from master to 7.x-1.x
Changed project to customize_links
Implemented few PAreview changes

jrattanpal’s picture

jrattanpal commented
Issue summary: View changes

Hi,

Thanks for your input. I have made the changes and ran RAreview (and Coder) on my code and fixed all the issues identified by those (except one but that is about line length due to link in readme.txt).

Please let me know if there is any other step that I need to follow..

Thanks

PA robot’s picture

PA robot commented

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Rkumar’s picture

Rkumar commented
Status: Needs review » Needs work

Change your git clone path.

Remove user name.

The path must be :-
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/jrattanpal/2235279.git customize_links.

jrattanpal’s picture

jrattanpal commented
Issue summary: View changes

Removing username from git path

mraichelson’s picture

mraichelson commented

@jrattanpal: Please take a closer look at the git clone command that Rkumar and I have posted above. The url used in the initial post should be modified to use the http:// url structure for the Git repo so that people besides the owner of the repository can clone it properly for review.

jrattanpal’s picture

jrattanpal commented
Issue summary: View changes

Adding http:// to GIT url

Thanks. Missed that small change.

jrattanpal’s picture

jrattanpal commented
Status: Needs work » Needs review
gmaheux’s picture

gmaheux commented

Hi jrattanpal,

It's a nice module.

Runs through pareview cleanly with only complaints about the name of readme.txt, you need to rename this file to README.txt. To remove the "project" line in your .info.

You can see this information here : http://pareview.sh/pareview/httpgitdrupalorgsandboxjrattanpal2235279git .

You need also to add the hook_uninstall() in your .install file to drop your table "customize_links" when you disable and uninstall your module.

Install without errors and testing without errors. Good job.

Cordially,

gmaheux’s picture

gmaheux commented
Status: Needs review » Needs work
PA robot’s picture

PA robot commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.