In my case, as specially with the prospect of inclusion of #1393928: Add a per-facet setting that allows only one item to be active at a time, I didn't want the parent items of a hierarchical facet to be set automatically when a children was selected, but rather treat them as individual items.

I could have patched the module for my needs but thought better to try to push a setting for it to be included.

CommentFileSizeAuthor
#9 setting-treat-parent-as-individual-facet-item-2244933-9-D7.patch3.7 KBhanoii
#5 2244933-5-facetapi-release-parent-bond.patch6 KBjustanothermark
#4 2244933-2-setting-treat-parent-as-individual-facet-items.patch3.7 KBhanoii
#1 2244933-1-setting-treat-parent-as-individual-facet-items.patch3.91 KBhanoii

Comments

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented
Status: Active » Needs review
StatusFileSize
new 2244933-1-setting-treat-parent-as-individual-facet-items.patch3.91 KB
hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented
Related issues: +#1393928: Add a per-facet setting that allows only one item to be active at a time

Status: Needs review » Needs work

The last submitted patch, 1: 2244933-1-setting-treat-parent-as-individual-facet-items.patch, failed testing.

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented
Status: Needs work » Needs review
StatusFileSize
new 2244933-2-setting-treat-parent-as-individual-facet-items.patch3.7 KB

Properly formatted patch.

justanothermark’s picture

justanothermark commented
StatusFileSize
new 2244933-5-facetapi-release-parent-bond.patch6 KB

I had a similar issue but didn't see this issue until after writing a patch. I haven't had chance to test the patch in #4 since I spent so long getting a working solution but I've included my patch as the approach is quite different.

My patch modifies FacetapiUrlProcessorStandard::getQueryString() to modify the created links so that clicking a child will remove the parent from the URL (for OR facets) and so that deactivating a child facet will enable the parent (i.e. only deselect the lowest level). However, this does involve changing the parameter passed through & therefore counts as an API change that could break other modules.

Status: Needs review » Needs work

The last submitted patch, 5: 2244933-5-facetapi-release-parent-bond.patch, failed testing.

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented

@justanothermark I know it's an extra mile, but your patch failed testing and you mentioned of an API change, mine does not change the API and passed tests, could you try it for your case and see if it works for you the same as yours? If it does at least we'll have another tester.

i will hide yours in the meantime to keep the issue with one patch to review for now.

khiminrm’s picture

khiminrm commented

@hanoii, thanks for the patch! It works for me. I also need such behavior for hierarchical facets.

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented
Status: Needs work » Needs review
StatusFileSize
new setting-treat-parent-as-individual-facet-item-2244933-9-D7.patch3.7 KB

bumping this one as the related issue was included, re-rolling for latest dev although patch still applies.

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented
cpliakas’s picture

cpliakas commented
Status: Needs review » Reviewed & tested by the community

Thanks for the contribution. Cool feature!

The patch works as advertised so marking as RTBC, however I do want to revisit the setting's name prior to releasing 7.x-1.5 just to make sure it is clear to people what it does. The description looks great, but as we know from UX studies people open don't reed the small gray text :-)

Thanks again, and great work.
Chris

cpliakas’s picture

cpliakas commented
Title: Setting to treat parent items as individual facet items » Allow parent terms in a hierarchy to be enabled / disabled independent of their children
Version: 7.x-1.3 » 7.x-1.x-dev

Changed title, added child issue at #2299543: Re-evaluate the name of the "Treat parent items as individual facet items" setting.

  • cpliakas committed 62aa313 on 7.x-1.x authored by hanoii 
    Issue #2244933 by hanoii: Allow parent terms in a hierarchy to be...

  • cpliakas committed ddf5c94 on authored by hanoii 
    Issue #2244933 by hanoii: Allow parent terms in a hierarchy to be...
cpliakas’s picture

cpliakas commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.