This module adds the Fluidbox javascript plugin to Drupal. It adds a field formatter so that a site builder can simply change the display of an image field to Fluidbox and it will be displayed in there.

In its development I have used Libraries API to add the library and have added the library by using render arrays. I have also included a drush make file to aid the site builder in obtaining the required libraries.

For more details on Fluidbox: http://terrymun.github.io/Fluidbox/

Sandbox Location: https://drupal.org/sandbox/kcmanc87/2244931

Git: git clone --branch 7.x-1.x http://git.drupal.org/sandbox/kcmanc87/2244931.git fluidbox

Other Reviews
-----

In order to help my application I have completed the following three reviews of other projects:

https://drupal.org/comment/8698803#comment-8698803
https://drupal.org/comment/8698819#comment-8698819
https://drupal.org/comment/8698853#comment-8698853

https://drupal.org/comment/8700845#comment-8700845

Comments

kevla’s picture

kevla CreditAttribution: kevla commented
Status: Active » Needs review
PA robot’s picture

PA robot CreditAttribution: PA robot commented

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

kevla’s picture

kevla CreditAttribution: kevla commented
Issue tags: +PAreview: review bonus
scotthooker’s picture

scotthooker CreditAttribution: scotthooker commented

Module works as intended. Like the inclusion of a .make file!

No issues in coding errors from pareview http://pareview.sh/pareview/httpgitdrupalorgsandboxkcmanc872244931git

Could perhaps look to include a hook_requirements in the install file to check to see if the library has been installed correctly.

kevla’s picture

kevla CreditAttribution: kevla commented

Hi scott,

Thanks for the advice and the review. I've implemented the hook_requirements now. I didn't know about that hook!

scotthooker’s picture

scotthooker CreditAttribution: scotthooker commented

No problem. Feel free to review my module ;)

I'll take a look at your update

kevla’s picture

kevla CreditAttribution: kevla commented
Issue summary: View changes

Added another review

kevla’s picture

kevla CreditAttribution: kevla commented
Priority: Normal » Major
heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn commented
Issue summary: View changes
heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn commented
Issue summary: View changes
heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn commented
Status: Needs review » Needs work

imagesreloaded provides a version so don't use fluidbox_get_version().

imagesLoaded PACKAGED v3.1.6

so also does fluidbox.

// Fluidbox
// Description: Replicating the seamless lightbox transition effect seen on Medium.com, with some improvements
// Version: 1.3.1a

Since fluidbox provides a min and non-minified version, why is imagesloaded using a minified version and fluidbox not?

Consider loading libraries with a minified and non-minified options and toggling that, either through and admin settings page or (less ideal) a hidden variable_get() that defaults to minified version.

kevla’s picture

kevla CreditAttribution: kevla commented

I'm sure there would be no problem just loading the minified version for both of them. I'll make that change.

I'll look into parsing the version numbers from those files. I'm unsure of how reliable they're going to be though if I just parse the strings.

kevla’s picture

kevla CreditAttribution: kevla commented
Priority: Major » Normal
Issue tags: -PAreview: review bonus

Changing priority back to normal and removing Review bonus as it has now had a review, which has stated that it requires wrk to be compliant to standards.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn commented

I tend to parse for a major version. If the format changes or version changes major versions, then I want to at least review the library and do some testing to make sure that it still works.

kevla’s picture

kevla CreditAttribution: kevla commented

I can easily parse the fluidbox one I think. it's just in JSON (composer.json)

The imagesloaded one I could do a regex for the version. It just doesn't really seem like the version on that has been put in any standardised way.

gmclelland’s picture

gmclelland CreditAttribution: gmclelland commented

You might can check the code in https://drupal.org/project/manualcrop. It has libraries integration and uses the imagesloaded library.

kevla’s picture

kevla CreditAttribution: kevla commented

Thanks, I should be able to lift that code straight out of it.

It is worth noting though that it was the dev version of manual crop that has it through libraries. Just drush dl'd it and was rather confused for a bit then!

PA robot’s picture

PA robot CreditAttribution: PA robot commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.