Problem/Motivation

Proposed resolution

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#13 interdiff.txt1.59 KBdawehner
#13 transaction-2245905-13.patch21.67 KBdawehner
#11 interdiff.txt2.66 KBdawehner
#11 fake_connection-2245905-10.patch21.42 KBdawehner
#8 interdiff.txt4.85 KBdawehner
#8 transaction-2245905-8.patch21.97 KBdawehner
#6 transaction-2245905-6.patch17.51 KBdawehner
#1 2245905.patch692 bytesdawehner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Active » Needs review
FileSize
2245905.patch692 bytes
chx’s picture

chx CreditAttribution: chx commented

Sure, why not. But won't this make the 'php' driver appear in the installer? If not, what keeps it from? I honestly do not know, I never even followed really the move of fake connection from migrate to driver.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

This function is somehow called when you have a transaction in your code. My goal is to use a fake connection for one of the tests, which uses a transaction internally.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

It seems not trivial support transaction support in PHP.

chx’s picture

chx CreditAttribution: chx commented

Sure it is: save the whole database array and on rollback put it back. It's good enough. It's not MVCC but then again you only have a single client with a single thread so you are good.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Title: Implement driver/driverType() for FakeConnection » Implement transaction support in the fake database driver
Issue tags: +PHPUnit
FileSize
transaction-2245905-6.patch17.51 KB

Well, I tried to get the test suite for transactions running, and here we go. This was fun!

Status: Needs review » Needs work

The last submitted patch, 6: transaction-2245905-6.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs work » Needs review
FileSize
transaction-2245905-8.patch21.97 KB
interdiff.txt4.85 KB

The test relied on public properties.

chx’s picture

chx CreditAttribution: chx commented 
    end($this->databaseContentsStack);
    $end = key($this->databaseContentsStack);
    return $this->databaseContentsStack[$end];

why not just return end($this->databaseContentsStack); ?

end() advances array's internal pointer to the last element, and returns its value. 

    end($this->databaseContentsStack);
    $end = key($this->databaseContentsStack);

end(array_keys($this->databaseContentsStack)) would perhaps be better but that's a strict notice. However, end((array_keys($this->databaseContentsStack))) works just fine. (Madness!) Compare http://3v4l.org/CNLVT to http://3v4l.org/168fi.

chx’s picture

chx CreditAttribution: chx commented

Apparently (( )) is classified as a https://bugs.php.net/bug.php?id=55222 bug so let's not do that.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
FileSize
fake_connection-2245905-10.patch21.42 KB
interdiff.txt2.66 KB

So let's try to improve the rest of the code.

chx’s picture

chx CreditAttribution: chx commented

Did you test this patch doesn't make the driver show up in the installer?
Also in popCommittableTransactions

        $last_entry = array_pop($this->databaseContentsStack);
        end($this->databaseContentsStack);
        $end = key($this->databaseContentsStack);
        $this->databaseContentsStack[$end] = $last_entry;

You are removing the second-to-last entry? But why? Anyways, this is best done with array_splice($this->databaseContentsStack, -2, 1)

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
FileSize
transaction-2245905-13.patch21.67 KB
interdiff.txt1.59 KB

Did you test this patch doesn't make the driver show up in the installer?

Just did, it does not appear.

You are removing the second-to-last entry? But why?

Well, the idea is to commit the one with $name, I guess the new code is a bit clearer.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 for Workday, Inc. commented
Version: 8.1.x-dev » 8.2.x-dev
Status: Needs review » Needs work
Issue tags: +Needs issue summary update

Patch no longer applies. Also tagging for an IS update since the IS is currently blank :)

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.