Hi,

within make_fake_tabs() function we have two usages of 'tabs' class, and it causes mark up issues in most of administration themes.
Examples:

In the same time, when tabs class removed from first wrapper, all looks ok in the most of popular themes.
So my proposition is to remove it.

CommentFileSizeAuthor
#1 7.x-3.1-panelizer-broken-tabs-markup-2247605-1.patch671 bytesIRuslan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

IRuslan’s picture

IRuslan CreditAttribution: IRuslan commented
FileSize
7.x-3.1-panelizer-broken-tabs-markup-2247605-1.patch671 bytes
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Version: 7.x-3.1 » 7.x-3.x-dev
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented

1: 7.x-3.1-panelizer-broken-tabs-markup-2247605-1.patch queued for re-testing.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Parent issue: » #2155813: Plan for Panelizer 7.x-3.2 release
mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman commented
Status: Needs review » Reviewed & tested by the community

Works for me, will help normalize any admin theme which adds padding/margin to .tabs

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Reviewed & tested by the community » Fixed

Thanks IRuslan for the patch and mglaman for the review. Committed!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.