A module for adding jQuery Backstretch functionality to Drupal

It provides following ways to add the background functionality to Drupal:>

1 - By adding images through comma seperated URLs
2 - By using the images from the ImageFields attached to nodes

You can also select on which pages the plugin should work.

There is already a module https://drupal.org/project/backstretch but it does not do things in simpler fashion and needed more options like which pages to show it on,custom URLs,ImageFields and transition times.

Repository
http://drupalcode.org/sandbox/xmaestro/2248975.git

Sandbox
https://drupal.org/sandbox/xmaestro/2248975

GitHub
https://github.com/xmaestro/jquery-backstretch-drupal

Demo and basic instructions:
http://sharpten.com/blog/jquery-backstretch-drupal

CommentFileSizeAuthor
#5 rariviewLOG.txt68.15 KBsunnyuff
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

PA robot’s picture

Status: Needs review » Needs work

Timeout when invoking pareview.sh for http://git.drupal.org/sandbox/xmaestro/2248975.git at http://pareview.sh/pareview/httpgitdrupalorgsandboxxmaestro2248975git

Do you have any third-party files committed? 3rd party code is not generally allowed on Drupal.org and should be deleted. This policy is described in the getting involved handbook. It also appears in the terms and conditions you agreed to when you signed up for Git access.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

xmaestro’s picture

Issue summary: View changes
xmaestro’s picture

Status: Needs work » Needs review
xmaestro’s picture

Priority: Normal » Major
sunnyuff’s picture

Priority: Major » Normal
Status: Needs review » Needs work
FileSize
68.15 KB

Hi Xmaestro,

Thanks for your contribution,

There are a lot of things which I noticed when I was reviewing the project, mentioned below :

  • Timeout when invoking pareview.sh : This is because you have added jquery.js in your module. So as per drupal guidelines you should not add any Third Party Libraries in your project.https://drupal.org/node/422996
    For any third party library which is required by the project should be loaded using the libraries module. Libraries
  • More than one .info files : A project should have only one info file.
  • Empty Folder : Please remove the empty folder.
  • Uncaught TypeError: undefined is not a function This plugin requires jquery version 1.7 or newer so you have to add a dependency on Jquery Update to work it smoothly. You also need to mention that in the Readme.

I have removed the jquery.js file and ran the pareview locally and you will find the log attached under.

As you already mentioned there is module named Backstretch Backstretch and I installed and checked the module, I saw it just don't support Image urls rather than that there is no much difference between the two modules. Also the other module is in production and supports context. If you really want the image urls please add a feature request to the current module though i don't think its a very useful feature since you can always download the images if you have the urls and add them. If you really want that feature please add a feature request for the current module. Adding almost same functionality with two different module is not a good idea, and as you may know that as a community we are into collaboration over competition.

PA robot’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.