There are still some locations throughout core that typehint using ConfigFacotry instead of ConfigFactoryInterface, as well as a couple of documentation mismatches.

CommentFileSizeAuthor
#3 interdiff-1-3.txt1.33 KBmartin107
#3 2253977-configFactoryInterface-typehinting-3.patch7.61 KBmartin107
#1 2253977-configFactoryInterface-typehinting-1.patch6.29 KBMixologic

Comments

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented
StatusFileSize
new 2253977-configFactoryInterface-typehinting-1.patch6.29 KB
Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented
Status: Active » Needs review
martin107’s picture

martin107 commented
StatusFileSize
new 2253977-configFactoryInterface-typehinting-3.patch7.61 KB
new interdiff-1-3.txt1.33 KB

FinishResponseSubscriber.php also had the same problem.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Good to go again ...

martin107’s picture

martin107 commented
Related issues: +#2265087: Flaw in core causing fatal error

I should have been more specific yesterday ...

#3 is a fix for a bug that is known to break at least one contrib module.

https://drupal.org/node/2265087.

dawehner’s picture

dawehner
Primary language German
commented
Issue tags: +Quick fix

So yeah, the question could be whether fatals in contrib modules could be at least a major.

moshe weitzman’s picture

moshe weitzman commented
Priority: Normal » Major

Since this blocks progress on devel for D8, I think we can go with Major.

How come WebProfiler gives a silent 500 error here. Could we make this problem easier to debug?

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

  • Commit c040367 on 8.x by webchick: 
    Issue #2253977 by martin107, Mixologic: Use ConfigFactoryInterface to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.