While this may be an undocumented feature, the display options allow an FPP entity's title to be displayed, but it doesn't show up.

FYI the Bean module had the same problem: #1858416: Rendered bean does not display the title when display settings indicate it should

CommentFileSizeAuthor
#20 fieldable_panels_panes-n2256503-12-backport-fpp15.patch3.02 KBdsnopek
#12 fieldable_panels_panes-n2256503-12.patch3.11 KBdamienmckenna
#11 fieldable_panels_panes-n2256503-11.patch3.17 KBdamienmckenna
#9 fieldable_panels_panes_n2256503-9.patch2.54 KBdsnopek
#7 fieldable_panels_panes-n2256503-7.patch1.02 KBdamienmckenna
#6 fieldable_panels_panes-n2256503-6.patch993 bytesdamienmckenna
#4 fieldable_panels_panes-n2256503-1.patch760 bytesdamienmckenna
#1 bean-n1858416-19.patch643 bytesdamienmckenna

Comments

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new bean-n1858416-19.patch643 bytes

Per suggestion from indytechcook, this has been added to PanelsPaneController->buildContent(), which is called by PanelsPaneController->view().

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

While it may not be the best approach to hardcode the HTML tag that's used, I think it's reasonable to use H2 as that's what block.tpl.php uses.

Status: Needs review » Needs work

The last submitted patch, 1: bean-n1858416-19.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new fieldable_panels_panes-n2256503-1.patch760 bytes

Wrong file. Doh.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new fieldable_panels_panes-n2256503-6.patch993 bytes

This version makes the title a link, if requested.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new fieldable_panels_panes-n2256503-7.patch1.02 KB

Forgot that the title field was optional, so only output it if it's not empty.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Needs review » Needs work

This patch works great! But, unfortunately, this will immediately cause the title to be displayed twice when using the FPP on a Panel (because it's already displaying it through Panels).

So, I think this needs two changes to make it really useful:

  1. The default display mode should have the 'Title' field marked as hidden, so out-of-the-box (and when people upgrade), they don't get suddenly hit with two titles being shown on a Panel
  2. There should be a "Preview" display mode that is used when showing FPPs in the admin pages (ie. /admin/structure/fieldable-panels-panes/view/%) which DOES show the 'Title' field by default

This would then work great in combination with #1588882: Use title for entity label when admin_title isn't present, when you have both the 'admin_title' and 'title' set. Otherwise, you only get to see the 'title' after clicking the 'Edit' tab.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Needs work » Needs review
StatusFileSize
new fieldable_panels_panes_n2256503-9.patch2.54 KB

Here is an updated version of this patch that makes the changes I described above in #8.

Please let me know what you think!

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #2244541: [meta] Plan for Fieldable Panels Pane 7.x-1.6 release
Related issues: +#2092477: Make pane title use view mode

@dsnopek: FYI I've just committed #2092477: Make pane title use view mode, so is this issue still necessary?

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new fieldable_panels_panes-n2256503-11.patch3.17 KB

This adds a short note to the README.txt file about the new view mode being used for the full display.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new fieldable_panels_panes-n2256503-12.patch3.11 KB

Rerolled.

Status: Needs review » Needs work

The last submitted patch, 12: fieldable_panels_panes-n2256503-12.patch, failed testing.

Status: Needs work » Needs review

DamienMcKenna queued 12: fieldable_panels_panes-n2256503-12.patch for re-testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue summary: View changes
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs review » Reviewed & tested by the community

Applies clean, works as detailed in comments above. When viewing the entity directly I now see the set title, when it's embedded as a pane only the pane title displays.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Reviewed & tested by the community » Fixed

Thanks for the review, mglaman. Committed!

  • DamienMcKenna committed fba17ce on 7.x-1.x 
    Issue #2256503 by DamienMcKenna, dsnopek: Title field logic improved,...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
StatusFileSize
new fieldable_panels_panes-n2256503-12-backport-fpp15.patch3.02 KB

Here is a backport of the patch which was committed to FPP 1.5. Feel free to ignore this! It's only useful if you want to include it in a .make file which uses FPP 1.5, rather than the latest -dev.