[D6] Change Content Status

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxbisw2257789git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

bisw, you have fatal security issue in your module:

$items['admin/setting/change_content_status/setting'] = array(
      'title' => 'Change Content Status',
      'page callback' => 'change_content_status',
      'file' => 'includes/change_content_status.inc',
      'access arguments' => array('access content'),
      'type' => MENU_NORMAL_ITEM,
);

'access arguments' => array('access content') means that everyone who can access your site will have permission to modify your nodes!

// Get all the nodes according to given date range and content type.
  $result = db_query("SELECT * FROM {node} WHERE created >= '%s' AND created <= '%s' $output", $from_date, $to_date);

  // Set node as publish.
  if ($node_status == 'publish') {
    while ($row_result = db_fetch_object($result)) {
      db_query("UPDATE {node} SET status = 1 WHERE nid = '%s'", $row_result->nid);
    }
  }
  else {
    while ($row_result = db_fetch_object($result)) {
      // Set node as non publish.
      db_query("UPDATE {node} SET status = 0 WHERE nid = '%s'", $row_result->nid);
    }
  }

Isn't this above too complex? I think it's possible to achieve same functionality with single SQL query which is much more efficient.

Module definitely needs more fine tuning

So this needs work. Please don't remove the security tag, we keep that for statistics and to show examples of security problems.

I'm not sure I understand the summary of what this module does, but it does seem from the screenshot like it's a use case that's already covered by Views Bulk Operations.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.