[D7] Trackduck

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxstattom2247875git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

The config page for this module is much more descriptive about what this module is about than the project description above.

The link "learn more on TrackDuck website" on the config page goes to a broken link.

It's not clear anywhere what I'm supposed to do with the script code the app.trackduck.com website gives me to insert in the site.

The @file comment in .install says "The installation instructions for the SMTP Authentication Support."

Coder says trackduck_init.js has this issue:
File: @file block missing (Drupal Docs) [comment_docblock_file]

trackduck.admin.inc line 9 says "Implements hook_settings_form()" but the function is named trackduck_configuration_form().

images on admin page does not have a proper URL, add base_path variable instead of hardcoded "/".
<img src="/' . drupal_get_path('module', 'trackduck') . '/images/chrome.png" alt="">

Other than that it seems to be working as expected and should be good to go once this is fixed.

When I will get permission to promote this project to full?

In due time. None of your reviewers have been git admins. Before a project is promoted to full, it must be vetted by a git admin. These are busy people, and it may take some time before they get around to yours. They may also find unresolved issues and set the status bak to "Needs work".

The git admins are currently quite busy with all the project applications and they're known prefer projects with a review bonus. If you help reviewing and put yourself on the high priority list they may get around to yours quicker.

Blocking issues:

1. Your module should remove all variables in hook_uninstall(), I think you're missing trackduck_status
2. In trackduck_configuration_form(), all user-facing text should be run through t() (and without html markup) to allow for multilingual sites

Non-blocking issues

• In _trackduck_add_script, can you use drupal_add_js() instead?

Those changes are minor and should be quick, hopefully we can get you promoted soon.

@stattom, "in due time" is at best an understatement. The current backlog of projects where the developer opted not to take advantage of the review "bonus" option is 43 weeks...

https://www.drupal.org/project/issues/projectapplications?status=14&orde...

Without the "bonus", at the current rate new reviews are requested by developers willing to do the "bonus" reviews and the small number of git admins willing to do reviews of projects without the "bonus", it is entirely possible your project will never be promoted.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.