I encountered a problem after installing Drupal Commons because the makefile adds two identically-named "media_oembed" modules, which causes the website to throw errors after installation when clearing caches or enabling/disabling modules.One of the media_oembed modules is a standalone project on Drupal.org, and the other is a submodule of the oembed project on Drupal.org. I've documented the problem in further detail in the oembed module's issue queue:
https://drupal.org/node/2226639
Drupal Commons needs to resolve this by either not including the separate media_oembed project or by patching the oembed module to remove the duplicate there.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | add-submodule-patch-2269745-3.patch | 647 bytes | devin carlson |
| #2 | remove-media-submodule-2269745-2.patch | 2.92 KB | devin carlson |
Comments
Comment #1
devin carlson commentedGood catch!
A patch to remove the Media: oEmbed submodule.
Comment #2
devin carlson commentedComment #3
devin carlson commentedAnd a patch to add the above patch to the Commons makefile.
Comment #4
japerryThere are three files in the registry that could potentially cause issues when upgrading from a previous version of oembed.MediaOEmbedStreamWrapper class profiles/commons/modules/contrib/oembed/deprecated/media_oembed/includes/MediaOEmbedStreamWrapper.inc media_oembed 0media_oembed_provider_ui class profiles/commons/modules/contrib/oembed/deprecated/media_oembed/plugins/export_ui/media_oembed_provider_ui.class.php media_oembed 0
MediaInternetOEmbedHandler class profiles/commons/modules/contrib/oembed/deprecated/media_oembed/includes/MediaInternetOEmbedHandler.inc media_oembed 0
On some setups, we would need to either run registry rebuild, or explicitly rename these (as well as the media_oembed path in the system table) to ensure that a missing class exception doesn't occur.Comment #5
japerryThe existing deprecated module doesn't include those classes, and when the upgrade was complete, it worked as expected. I think the problem was around it trying to switch between the two modules before I applied the patch. Once the patch was applied and I disabled/re-enabled the module everything worked.
I' think we're good here.
Comment #6
devin carlson commentedI've retested #3 with a fresh Commons install and got the same results as outlined in #5.
Committed #3 to Commons 7.x-3.x.
Comment #8
sheldon rampton commented@Devin Carlson, what's your plan for the media_oembed module within oembed? Are you planning to remove it there and just have the standalone module? In the ticket I filed separately in the oembed module's issue queue, user sunnz expressed a preference to have media_oembed remain a part of oembed:
https://drupal.org/node/2226639
I don't have a preference personally, but it shouldn't exist in two places.