[D7] Ubercart Legal integration

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxsantiwww2270463git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Manual Review

I can't test this as I don't have a working Ubercart install.

This module is rather brief, but if the Legal module doesn't do this with UC out of the box, then I would say this could be useful for people.

Your README.txt should mention that the T&C need to be set in the Legal module, and you
probably also want to include that path.

uc_legal_integration:43 Use user_is_anonymous() instead of checking $user->uid

Your project page should mention the similar modules, and needs a little TLC with formatting.
I also think you could expand the explanation of how this is different.

I don't see anything that would prevent RBTC.

Automated Review

Review of the 7.x-1.x branch:

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards).

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

FILE: /home/matt/tmp/pareview_temp/README.txt
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 27 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

Very minor.

Manual Review

Not seeing anything worth holding this up. As I mention in a previous comment, this is short and technically doesn't meet the 120 line / 5 function
requirement. However, as this module leverages both the UC and Legal API extensively which is why it is short, so I am making an exception in this case.

And as this has been setting RBTC for a while now without objection...

Thanks for your contribution, santiwww!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.