[D7] DocRaptor PDF Library [#2271545]

This module is a PDF Library addon for the Print module that allows you to generate the PDF version of an HTML page using the DocRaptor API. http://docraptor.com

DocRaptor makes it easy to create PDF and XLS files on the fly. You just send HTML and CSS, and you get back beautiful, high quality documents at scale.

I needed to create this module because the open source options for html to pdf conversion can't handle large documents. I've tested sending 300 page nodes to docraptor with no issues.

Use of this module requires an API key provided by DocRaptor. A 7 day free trial is available from them for testing out the features. Additionally, i've provided a setting in the module to submit documents in "test mode" which watermarks the PDFs and doesn't count towards paid plan limits.

Project Page:
https://drupal.org/sandbox/apmsooner/2271521

Git:
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/apmsooner/2271521.git docraptor_pdf_library

Reviews:
to come

Comments

Comment #1

apmsooner CreditAttribution: apmsooner commented 21 May 2014 at 06:53

Issue summary:

View changes

Comment #2

sunnyuff CreditAttribution: sunnyuff commented 21 May 2014 at 09:40

Status:

Needs review

» Needs work

Hi there,

your code looks clean and good to me, but there are quite a few issues to sort out such as indentation, whitespace etc.

You can find them all here:
http://pareview.sh/pareview/httpgitdrupalorgsandboxapmsooner2271521git

best of luck with your project!

Comment #3

apmsooner CreditAttribution: apmsooner commented 21 May 2014 at 16:56

Status:

Needs work

» Needs review

Thanks for your review @sunnyuff. I've fixed all coding issues.

Comment #4

PA robot CreditAttribution: PA robot commented 21 May 2014 at 22:23

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Comment #5

neetu morwani CreditAttribution: neetu morwani commented 3 June 2014 at 19:35

Status:

Needs review

» Needs work

@apmsooner
Code looks clean. No errors found.
1. But the most important issue which is missed out is -> Correct link of the git repository which helps user in cloning the module which is wrong in your case.
Instead it should be
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/apmsooner/2271521.git docraptor_pdf_library
Git repository link mentioned by you is - git clone --branch 7.x-1.x apmsooner@git.drupal.org:sandbox/apmsooner/2271521.git docraptor_pdf_library which asks password for apmsooner which should not be the case.
2. README.txt file lists dependency on module print_pdf.
https://drupal.org/project/print_pdf page is not found.
The module print_pdf comes in the print package. Therefore dependency should be set on Print module.
Fix these issues, otherwise everything looks good.

Comment #6

apmsooner CreditAttribution: apmsooner commented 3 June 2014 at 22:30

Issue summary:

View changes

Comment #7

apmsooner CreditAttribution: apmsooner commented 3 June 2014 at 22:32

Thanks Neetu,
I corrected the git repository link and I will push an update for the readme.txt as soon as i get a chance.

Appreciate the review!

Comment #8

apmsooner CreditAttribution: apmsooner commented 4 June 2014 at 20:59

Status:

Needs work

» Needs review

@neetu,

As for #2, readme.txt file does not specify print_pdf as dependency. The .info specified print_pdf as a dependency and the reason you didn't find it via /projects/print_pdf is because it is a sub-module for /projects/print. I updated .info file with the additional dependency of the "print" module just the same. I would appreciate your followup and status change of RBTC if you agree this satisfies the issue.

Thanks

Comment #9

PA robot CreditAttribution: PA robot commented 30 June 2014 at 22:23

Status:

Needs review

» Closed (duplicate)

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2295359

Project 2: https://www.drupal.org/node/2271545

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.