SUMMARY

The module allows content authors to write in Bootstrap style in a easier way.

- Automatically applying responsive style to all images.

- Using Glyphicons (http://getbootstrap.com/components/) in a simpler way.

For example:
Using <g-search>, instead of <span class="glyphicon glyphicon-search"></span>
Using <g-plus>, instead of <span class="glyphicon glyphicon-plus"></span>

REQUIREMENTS

Bootstrap library

simplehtmldom

INSTALLATION

Install as usual, see http://drupal.org/node/70151 for further information.

CONFIGURATION

Apply the bootstrap file to some formats (Content authoring -> Text formats).

PROJECT PAGE

https://drupal.org/sandbox/henry/2273263

Comments

PA robot’s picture

Status: Active » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxhenry2273263git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

henryhu’s picture

Issue summary: View changes
henryhu’s picture

Issue summary: View changes
henryhu’s picture

Status: Needs work » Needs review
ragnarkurm’s picture

Status: Needs review » Needs work

Did a quick check to proposed module.

  • On you Application page and on your Project page there should be git clone ... - Needs work
  • Project page is almost nonexistent. Needs to be filled in, check other project pages. - Needs documentation.
  • README.txt is also a bit too short. - Needs documentation.
  • It states the requirement is Bootstrap library. Where should I find it? How to install? - Needs documentation.
  • There is no hint about it and how to configure the module. Only module name hints it. - Needs documentation.
  • Is this filter compatible with other text filters? - Needs documentation.
  • If Bootstrap library is not installed then I should be able to see it from Status Report. - Needs work.
  • Project contains 3 short functions and 55 lines. Minimum is 5 functions and 120 lines of self-written code. - Needs work.
  • Function names must start with module name, not with underscore. - Need work
  • You module changes images to responsive. This was not advertised and out of scope. - Needs work.

    // Responsive images.
      foreach ($html_obj->find('img') as $img) {
        $img->class = 'img-responsive';
      }
  • Are you aware of Bootstrap module? - Real blocker.

    Glyphicon support via the Icon API module. Allows Bootstrap icons to be inserted into menu items, fields, blocks and in text fields via a text format filter.

I confirm that the module does short-tag replacement as advertised.

PA robot’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.