[D7] countryicons_bw

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi alarez,

Your module seems to be an error and did not passed pareview test see this link:
http://pareview.sh/pareview/httpgitdrupalorgsandboxalarez2273853git

Here are some quick issues to get started:
- The git clone is your personal git URL. This is your public Git clone command:
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/alarez/2273853
- You should delete your master branch, according to https://drupal.org/empty-git-master
- Take a look at the automated code review results here:
http://pareview.sh/pareview/httpgitdrupalorgsandboxalarez2273853git

Just install a new Drupal site with https://drupal.org/project/countryicons and https://drupal.org/project/countries

Tested the 2 set of countries flags (large, 60x40) and (small, 14x11) and it works fine.

Screenshot attached

Work fine for me.

I run the pareview test again http://pareview.sh/pareview/httpgitdrupalorgsandboxalarez2273853git and it pass

Nice, it will be great to have additional sets.

Firstly no significant issues with a manual code review. Normally I would say this is the wrong package, but this groups it with the parent module, so just in case some one complains, this is the best spot!

The readme should be renamed back ;)

Every contributed project should provide a README.txt in the package. This file should contain a basic overview of what the module does and how someone may use it.

May I ask what the icon source is? There are possible copyright issues here; maybe state the source in the readme and make sure that they are released in a GPL compatible license or get permission from the original author to release these with that.

@alarez, thankyou for your contribution.

I appreciate your module idea but it is too short. Here are my comments after reviewing your module.

Automated Review

Best practice issues identified by pareview.sh / drupalcs / coder. None.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

(*) Maybe: Does not cause module duplication and fragmentation. Can you follow the steps in the link and confirm that the functionality contained in this module should stay separate from Country Icons and Countries?

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party code

Yes: Follows the guidelines for 3rd party code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and the README Template.

Code long/complex enough for review

(*) No: Follows the guidelines for project length and complexity. Contains around 20 lines of code after removing comments.

Secure code

Yes. If "no", list security issues identified.

Coding style & Drupal API usage

1. (+) hook_help() is missing in this module.
2. (*) It contains just only one hook function with around 20 lines of code, difficult to considering as a separate module. I would recommend you to either you add some more features in this or add this as a feature to some existing module as mentioned above.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

As I am not a git administrator, so I would recommend you, please help to review other project applications to get a review bonus. This will put you on the high priority list, then git administrators will take a look at your project right away :-)

Thanks Again!

Repeating myself from https://www.drupal.org/node/2316793#comment-9037065 here: short modules are perfectly fine.

Addressed Pushpinder points below.

Since the other points all passed by Pushpinder, I am flagging this as rtbtc with the recommendation that a git admin pushes this. :)

hook_help()
I do not think that this would be applicable as the functionality of this is just to provide additional icon sets.

No duplication
Countries - has nothing to do with the icons
Country Icons - provides the base API (that single hook) only. The idea is that this module does not bloat with multiple icon sets.

It contains just only one hook function with around 20 lines of code, difficult to considering as a separate module.
Icon sets are separate projects by design, so no issue there per say. The IP here is in the icons themselves.

i.e. Similar modules that provide icons.

https://www.drupal.org/project/countryicons_shiny
https://www.drupal.org/project/countryicons_gosquared

If this is an issue (git access), I'd suggest that an admin publishes this for Alain. As per the page referenced about project length states:

This does not mean that short projects will never get approved, a git admin can promote a project on behalf of the user without giving the git vetted user role to them

@Alain
Sorry, just read this "All contributed modules should provide a README.txt or README.md file in the package", there was no need to rename (or not now anyway) :/

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2316863

Project 2: https://www.drupal.org/node/2273887

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2273887

Project 2: https://www.drupal.org/node/2316863

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

Updating git clone command

The user who is applying cannot change the status to reviewed & tested by the community: that needs to be done from somebody else.

I reviewed the module, and didn't find anything wrong.

Thank you for your contribution!

I am going to update your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions
• Helping maintainers in the issue queues

You can find more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thank you, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thank you to the dedicated reviewer(s) as well.